Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324632: Update Zlib Data Compression Library to Version 1.3.1 #17619

Closed
wants to merge 1 commit into from

Conversation

LanceAndersen
Copy link
Contributor

@LanceAndersen LanceAndersen commented Jan 29, 2024

Hi all,

Please review this PR which updates zlib from 1.3 to 1.3.1 in OpenJDK

The Zlib Data Compression Library has released Zlib 1.3.1 on January 24, 2024.

There are a small number of updates between 1.3 and 1.3.1

Mach5 tiers1-3 have run clean


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8324632: Update Zlib Data Compression Library to Version 1.3.1 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17619/head:pull/17619
$ git checkout pull/17619

Update a local copy of the PR:
$ git checkout pull/17619
$ git pull https://git.openjdk.org/jdk.git pull/17619/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17619

View PR using the GUI difftool:
$ git pr show -t 17619

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17619.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 29, 2024

👋 Welcome back lancea! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 29, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@LanceAndersen The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 29, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 29, 2024

Webrevs

@AlanBateman
Copy link
Contributor

@LanceAndersen Can you confirm that there are no changes to the 1.3..1.3.1 diffs?

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've spot-checked these files against the referenced diffs between v1.3.1 and v1.3 and confirm that they are as expected.

@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@LanceAndersen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324632: Update Zlib Data Compression Library to Version 1.3.1

Reviewed-by: iris, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

  • a1d65eb: 8324125: Improve class initialization barrier in TemplateTable::_new for RISC-V
  • b6d364a: 8324865: windows-x64-slowdebug still does not build after JDK-8324840
  • 64c3642: 8242564: javadoc crashes:: class cast exception com.sun.tools.javac.code.Symtab$6
  • e999dfc: 8323503: x86: Shorter movptr(reg, imm) for 32-bit unsigned immediates
  • 84deeb6: 8324667: fold Parse::seems_stable_comparison()
  • fb07bbe: 8324717: Remove HotSpotJVMCICompilerFactory
  • d1e6763: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653
  • c1281e6: 8324678: Replace NULL with nullptr in HotSpot gtests
  • a6bdee4: 8324681: Replace NULL with nullptr in HotSpot jtreg test native code files
  • 951b5f8: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
  • ... and 52 more: https://git.openjdk.org/jdk/compare/8c003d83c450a1e706ec5e5ba3d319d84fc4b584...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 29, 2024
@LanceAndersen
Copy link
Contributor Author

@LanceAndersen Can you confirm that there are no changes to the 1.3..1.3.1 diffs?

@AlanBateman, yes that is correct, there are no OpenJDK specific changes, it is a straight port of the zlib 1.3.1 changes to our implementation

@LanceAndersen
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 31, 2024

Going to push as commit b5c267f.
Since your change was applied there have been 74 commits pushed to the master branch:

  • ec56c72: 8323601: Improve LayoutPath.PathElement::toString
  • f7121de: 8322648: Improve class initialization barrier in TemplateTable::_new for PPC
  • 577de17: 8259550: The content of the print out displayed incomplete with the NimbusLAF
  • 83b3c9b: 8322649: Improve class initialization barrier in TemplateTable::_new for S390
  • 7d1a488: 8324861: Exceptions::wrap_dynamic_exception() doesn't have ResourceMark
  • c3c1d5b: 8324998: Add test cases for String.regionMatches comparing Turkic dotted/dotless I with uppercase latin I
  • 8892d45: 8324582: Replace -Djava.util.concurrent.ForkJoinPool.common.parallelism to -Djdk.virtualThreadScheduler.maxPoolSize in jvmti vthread tests
  • 11e28bd: 8324794: C2 SuperWord: do not ignore reductions in SuperWord::unrolling_analysis
  • d51aaf6: 8323950: Null CLD while loading shared lambda proxy class with javaagent active
  • f57c722: 8324880: Rename get_stack_trace.h
  • ... and 64 more: https://git.openjdk.org/jdk/compare/8c003d83c450a1e706ec5e5ba3d319d84fc4b584...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 31, 2024
@openjdk openjdk bot closed this Jan 31, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 31, 2024
@openjdk
Copy link

openjdk bot commented Jan 31, 2024

@LanceAndersen Pushed as commit b5c267f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants