Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8196092: javax/swing/JComboBox/8032878/bug8032878.java fails #1762

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Dec 14, 2020

Test was failing if JComboBox tests was run in group in nightly mach5 testing.
Modified test to remove dependancy from Util class, added delay before frame show and move frame to centre of screen.
Resultant modified test ran fine in JComboBox group and also in standalone, several iterations of which are ran in mach5. Link in JBS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8196092: javax/swing/JComboBox/8032878/bug8032878.java fails

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1762/head:pull/1762
$ git checkout pull/1762

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2020

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 14, 2020
@openjdk
Copy link

openjdk bot commented Dec 14, 2020

@prsadhuk The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing client-libs-dev@openjdk.org label Dec 14, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 14, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 14, 2020

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8196092: javax/swing/JComboBox/8032878/bug8032878.java fails

Reviewed-by: serb, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • c30fff7: 8257229: gtest death tests fail with unrecognized stderr output

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 14, 2020
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Dec 14, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 14, 2020
@openjdk
Copy link

openjdk bot commented Dec 14, 2020

@prsadhuk Since your change was applied there has been 1 commit pushed to the master branch:

  • c30fff7: 8257229: gtest death tests fail with unrecognized stderr output

Your commit was automatically rebased without conflicts.

Pushed as commit 2ee795d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8196092 branch December 14, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated swing client-libs-dev@openjdk.org
3 participants