8324937: GHA: Avoid multiple test suites per job

[shipilev]

See the description in the bug. This mitigates the issue by splitting out the only test job that has two test suites in it.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8324937: GHA: Avoid multiple test suites per job (Bug - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)
• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17627/head:pull/17627
$ git checkout pull/17627

Update a local copy of the PR:
$ git checkout pull/17627
$ git pull https://git.openjdk.org/jdk.git pull/17627/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17627

View PR using the GUI difftool:
$ git pr show -t 17627

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17627.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c7188aca)

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324937: GHA: Avoid multiple test suites per job

Reviewed-by: erikj, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• a663248: 8324668: JDWP process management needs more efficient file descriptor handling
• a2229b1: 8324838: test_nmt_locationprinting.cpp broken in the gcc windows build
• 432756b: 8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information
• fe78c0f: 8325022: Incorrect error message on client authentication
• 5b9b176: 8324174: assert(m->is_entered(current)) failed: invariant
• 0cc8e5b: 8325042: remove unused JVMDITools test files
• f292053: 8323621: JDK build should exclude snippet class in java.lang.foreign
• 62c9530: 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg
• 1f2922a: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java
• 2cd1ba6: 8324981: Shenandoah: Move commit and soft max heap changed methods into heap
• ... and 16 more: https://git.openjdk.org/jdk/compare/fd8adf308357355bd33916ad80e2328c35434e5a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[magicus]

I think this combination of two tests were made due to fear of too much overhead of creating a small test suite, or something like that. Is there anything in the reasoning that brought us this solution that is still relevant, or was it just a premature optimization that is causing us headache now?

[shipilev]

or was it just a premature optimization that is causing us headache now?

This one. When I did this originally, I thought why have another job when we can stash some groups together? But the cost for additional job is not actually that high: the job completes in less than 2 minutes. It is completely dominated by everything else.

[shipilev]

I would like to integrate this, if you have no further comments, @magicus ?

[shipilev]

/integrate

[openjdk]

Going to push as commit 1aba78f.
Since your change was applied there have been 26 commits pushed to the master branch:

• a663248: 8324668: JDWP process management needs more efficient file descriptor handling
• a2229b1: 8324838: test_nmt_locationprinting.cpp broken in the gcc windows build
• 432756b: 8325024: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java incorrect comment information
• fe78c0f: 8325022: Incorrect error message on client authentication
• 5b9b176: 8324174: assert(m->is_entered(current)) failed: invariant
• 0cc8e5b: 8325042: remove unused JVMDITools test files
• f292053: 8323621: JDK build should exclude snippet class in java.lang.foreign
• 62c9530: 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg
• 1f2922a: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java
• 2cd1ba6: 8324981: Shenandoah: Move commit and soft max heap changed methods into heap
• ... and 16 more: https://git.openjdk.org/jdk/compare/fd8adf308357355bd33916ad80e2328c35434e5a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 1aba78f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.