JDK-8257959: Add gtest run with -XX:+UseLargePages

[tstuefe]

Hi,

may I please have reviews for this addition.

To better test changes in large page handling, it makes sense to regularly run gtests with large pages enabled. Not the whole gtest suite needs to be run, but at least the os* part.

Thanks, Thomas

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8257959: Add gtest run with -XX:+UseLargePages

Reviewers

• Lois Foltan (@lfoltan - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1763/head:pull/1763
$ git checkout pull/1763

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (21da508)

[lfoltan]

Looks good.
Lois

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257959: Add gtest run with -XX:+UseLargePages

Reviewed-by: lfoltan, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 386 new commits pushed to the master branch:

• 707bce0: 8257212: (bf spec) Clarify byte order of the buffer returned by CharBuffer.subsequence(int,int)
• 0ec2c96: 8259820: JShell does not handle -source 8 properly
• b01a15e: 8258884: [TEST_BUG] Convert applet-based test open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java to a regular java test
• 6d4a593: 8259627: Potential memory leaks in JVMTI after JDK-8227745
• 2c8e337: 8259622: TreeMap.computeIfAbsent deviates from spec
• d701bab: Merge
• 4307fa6: 8253505: JFR: onFlush invoked out of order with a sorted event stream
• 0148adf: 8255120: C2: assert(outer->outcnt() >= phis + 2 && outer->outcnt() <= phis + 2 + stores + 1) failed: only phis
• 90960c5: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed
• e3b548a: 8257736: InputStream from BodyPublishers.ofInputStream() leaks when IOE happens
• ... and 376 more: https://git.openjdk.java.net/jdk/compare/c30fff7c329f1542c67df1500873ca663e7e3e70...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

Looks good.
Lois

Thank you Lois!

[bridgekeeper]

@tstuefe This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[tstuefe]

Gentle ping. May I have another review please?

[tschatzl]

Lgtm

[tstuefe]

Lgtm

Thanks, Thomas!

[tstuefe]

/integrate

[openjdk]

@tstuefe Since your change was applied there have been 386 commits pushed to the master branch:

• 707bce0: 8257212: (bf spec) Clarify byte order of the buffer returned by CharBuffer.subsequence(int,int)
• 0ec2c96: 8259820: JShell does not handle -source 8 properly
• b01a15e: 8258884: [TEST_BUG] Convert applet-based test open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java to a regular java test
• 6d4a593: 8259627: Potential memory leaks in JVMTI after JDK-8227745
• 2c8e337: 8259622: TreeMap.computeIfAbsent deviates from spec
• d701bab: Merge
• 4307fa6: 8253505: JFR: onFlush invoked out of order with a sorted event stream
• 0148adf: 8255120: C2: assert(outer->outcnt() >= phis + 2 && outer->outcnt() <= phis + 2 + stores + 1) failed: only phis
• 90960c5: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed
• e3b548a: 8257736: InputStream from BodyPublishers.ofInputStream() leaks when IOE happens
• ... and 376 more: https://git.openjdk.java.net/jdk/compare/c30fff7c329f1542c67df1500873ca663e7e3e70...master

Your commit was automatically rebased without conflicts.

Pushed as commit bbac91a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.