Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324974: JFR: EventCompilerPhase should be created as UNTIMED #17632

Closed
wants to merge 1 commit into from

Conversation

D-D-H
Copy link
Contributor

@D-D-H D-D-H commented Jan 30, 2024

Hi,

Please help review this fix.

CompilerEvent::PhaseEvent::post will set the _start_time of EventCompilerPhase, so EventCompilerPhase should be created as UNTIMED.

Thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8324974: JFR: EventCompilerPhase should be created as UNTIMED (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17632/head:pull/17632
$ git checkout pull/17632

Update a local copy of the PR:
$ git checkout pull/17632
$ git pull https://git.openjdk.org/jdk.git pull/17632/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17632

View PR using the GUI difftool:
$ git pr show -t 17632

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17632.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 30, 2024

👋 Welcome back ddong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 30, 2024
@openjdk
Copy link

openjdk bot commented Jan 30, 2024

@D-D-H The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Jan 30, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 30, 2024

Webrevs

@D-D-H
Copy link
Contributor Author

D-D-H commented Jan 30, 2024

/label add hotspot-jfr

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Jan 30, 2024
@openjdk
Copy link

openjdk bot commented Jan 30, 2024

@D-D-H
The hotspot-jfr label was successfully added.

@D-D-H
Copy link
Contributor Author

D-D-H commented Jan 31, 2024

testing: jdk/jfr all passed. (release build)

@openjdk
Copy link

openjdk bot commented Jan 31, 2024

@D-D-H This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324974: JFR: EventCompilerPhase should be created as UNTIMED

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 1733d2e: 8303374: Implement JEP 455: Primitive Types in Patterns, instanceof, and switch (Preview)
  • 6697160: 8320712: Rewrite BadFactoryTest in pure Java
  • 725314f: 8324771: Obsolete RAMFraction related flags
  • ec6c35c: 8324970: Serial: Refactor signature of maintain_old_to_young_invariant
  • b5c267f: 8324632: Update Zlib Data Compression Library to Version 1.3.1
  • ec56c72: 8323601: Improve LayoutPath.PathElement::toString
  • f7121de: 8322648: Improve class initialization barrier in TemplateTable::_new for PPC
  • 577de17: 8259550: The content of the print out displayed incomplete with the NimbusLAF
  • 83b3c9b: 8322649: Improve class initialization barrier in TemplateTable::_new for S390
  • 7d1a488: 8324861: Exceptions::wrap_dynamic_exception() doesn't have ResourceMark
  • ... and 5 more: https://git.openjdk.org/jdk/compare/f0024f585dcc1d8afe5808bf626efd8f514da070...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 31, 2024
@D-D-H
Copy link
Contributor Author

D-D-H commented Feb 1, 2024

/integrate

Thanks for the review.

@openjdk
Copy link

openjdk bot commented Feb 1, 2024

Going to push as commit 6b09a79.
Since your change was applied there have been 34 commits pushed to the master branch:

  • 70e7cdc: 8323670: A few client tests intermittently throw ConcurrentModificationException
  • ac1cd31: 8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing
  • 8e45182: 8324834: Use _LARGE_FILES on AIX
  • cab74b0: 8324287: Record total and free swap space in JFR
  • 6b84f9b: 8325001: Typo in the javadocs for the Arena::ofShared method
  • cd11059: 8325053: Serial: Move Generation::save_used_region to TenuredGeneration
  • d9331bf: 8324845: management.properties text "interface name" is misleading
  • 68206b5: 8324585: JVM native memory leak in PCKS11-NSS security provider
  • 1aba78f: 8324937: GHA: Avoid multiple test suites per job
  • a663248: 8324668: JDWP process management needs more efficient file descriptor handling
  • ... and 24 more: https://git.openjdk.org/jdk/compare/f0024f585dcc1d8afe5808bf626efd8f514da070...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 1, 2024
@openjdk openjdk bot closed this Feb 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2024
@openjdk
Copy link

openjdk bot commented Feb 1, 2024

@D-D-H Pushed as commit 6b09a79.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants