-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8324974: JFR: EventCompilerPhase should be created as UNTIMED #17632
Conversation
👋 Welcome back ddong! A progress list of the required criteria for merging this PR into |
/label add hotspot-jfr |
@D-D-H |
testing: jdk/jfr all passed. (release build) |
@D-D-H This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate Thanks for the review. |
Going to push as commit 6b09a79.
Your commit was automatically rebased without conflicts. |
Hi,
Please help review this fix.
CompilerEvent::PhaseEvent::post will set the _start_time of EventCompilerPhase, so EventCompilerPhase should be created as UNTIMED.
Thanks.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17632/head:pull/17632
$ git checkout pull/17632
Update a local copy of the PR:
$ git checkout pull/17632
$ git pull https://git.openjdk.org/jdk.git pull/17632/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17632
View PR using the GUI difftool:
$ git pr show -t 17632
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17632.diff
Webrev
Link to Webrev Comment