8324998: Add test cases for String.regionMatches comparing Turkic dotted/dotless I with uppercase latin I

[eirbjo]

Please review this test-only PR which improves test coverage of String.regionMatches when comparing the Turkic "dotted I" and "dotless i" characters with their latin cousins.

The test CompactStrings/RegionMatches.java currently includes cases comparing these characters against the lowercase latin "i" character, but not against the corresponding uppercase latin "I" character. It would be good to add test cases for the uppercase I as well.

This was originally found in #12637, which was closed without being integrated. I think this test coverage enhancement is worth rescuing from that PR, where it did prove to catch a regression.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8324998: Add test cases for String.regionMatches comparing Turkic dotted/dotless I with uppercase latin I (Enhancement - P4)

Reviewers

• Naoto Sato (@naotoj - Reviewer)
• Iris Clark (@irisclark - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17639/head:pull/17639
$ git checkout pull/17639

Update a local copy of the PR:
$ git checkout pull/17639
$ git pull https://git.openjdk.org/jdk.git pull/17639/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17639

View PR using the GUI difftool:
$ git pr show -t 17639

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17639.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back eirbjo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@eirbjo The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (91b57e5a)

[naotoj]

Looks reasonable to me.

[openjdk]

@eirbjo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324998: Add test cases for String.regionMatches comparing Turkic dotted/dotless I with uppercase latin I

Reviewed-by: naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 228 new commits pushed to the master branch:

• 8892d45: 8324582: Replace -Djava.util.concurrent.ForkJoinPool.common.parallelism to -Djdk.virtualThreadScheduler.maxPoolSize in jvmti vthread tests
• 11e28bd: 8324794: C2 SuperWord: do not ignore reductions in SuperWord::unrolling_analysis
• d51aaf6: 8323950: Null CLD while loading shared lambda proxy class with javaagent active
• f57c722: 8324880: Rename get_stack_trace.h
• f0024f5: 8324734: Relax too-strict assert(VM_Version::supports_evex()) in Assembler::locate_operand()
• fd8adf3: 8324856: Serial: Move Generation::is_in to DefNewGeneration
• a1d65eb: 8324125: Improve class initialization barrier in TemplateTable::_new for RISC-V
• b6d364a: 8324865: windows-x64-slowdebug still does not build after JDK-8324840
• 64c3642: 8242564: javadoc crashes:: class cast exception com.sun.tools.javac.code.Symtab$6
• e999dfc: 8323503: x86: Shorter movptr(reg, imm) for 32-bit unsigned immediates
• ... and 218 more: https://git.openjdk.org/jdk/compare/e10d14004fa25998231ab1d2611b75aea9b5c67d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[eirbjo]

/integrate

[openjdk]

Going to push as commit c3c1d5b.
Since your change was applied there have been 228 commits pushed to the master branch:

• 8892d45: 8324582: Replace -Djava.util.concurrent.ForkJoinPool.common.parallelism to -Djdk.virtualThreadScheduler.maxPoolSize in jvmti vthread tests
• 11e28bd: 8324794: C2 SuperWord: do not ignore reductions in SuperWord::unrolling_analysis
• d51aaf6: 8323950: Null CLD while loading shared lambda proxy class with javaagent active
• f57c722: 8324880: Rename get_stack_trace.h
• f0024f5: 8324734: Relax too-strict assert(VM_Version::supports_evex()) in Assembler::locate_operand()
• fd8adf3: 8324856: Serial: Move Generation::is_in to DefNewGeneration
• a1d65eb: 8324125: Improve class initialization barrier in TemplateTable::_new for RISC-V
• b6d364a: 8324865: windows-x64-slowdebug still does not build after JDK-8324840
• 64c3642: 8242564: javadoc crashes:: class cast exception com.sun.tools.javac.code.Symtab$6
• e999dfc: 8323503: x86: Shorter movptr(reg, imm) for 32-bit unsigned immediates
• ... and 218 more: https://git.openjdk.org/jdk/compare/e10d14004fa25998231ab1d2611b75aea9b5c67d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@eirbjo Pushed as commit c3c1d5b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.