Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324960: Unsafe.allocateMemory documentation incorrect regarding zero return value #17643

Closed
wants to merge 1 commit into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Jan 31, 2024

Align the specification of Unsafe.allocateMemory with its implementation and with the specification of Unsafe.reallocateMemory.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8325149 to be approved

Issues

  • JDK-8324960: Unsafe.allocateMemory documentation incorrect regarding zero return value (Bug - P4)
  • JDK-8325149: Unsafe.allocateMemory documentation incorrect regarding zero return value (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17643/head:pull/17643
$ git checkout pull/17643

Update a local copy of the PR:
$ git checkout pull/17643
$ git pull https://git.openjdk.org/jdk.git pull/17643/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17643

View PR using the GUI difftool:
$ git pr show -t 17643

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17643.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 31, 2024

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 31, 2024
@openjdk
Copy link

openjdk bot commented Jan 31, 2024

@bplb The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 31, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 31, 2024

Webrevs

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openjdk
Copy link

openjdk bot commented Feb 1, 2024

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324960: Unsafe.allocateMemory documentation incorrect regarding zero return value

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 68 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 1, 2024
@bplb
Copy link
Member Author

bplb commented Feb 1, 2024

lgtm

Thanks @RogerRiggs.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration and removed ready Pull request is ready to be integrated labels Feb 1, 2024
@bplb
Copy link
Member Author

bplb commented Feb 1, 2024

CSR created.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Feb 5, 2024
@bplb
Copy link
Member Author

bplb commented Feb 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Feb 5, 2024

Going to push as commit 209d87a.
Since your change was applied there have been 68 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 5, 2024
@openjdk openjdk bot closed this Feb 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 5, 2024
@openjdk
Copy link

openjdk bot commented Feb 5, 2024

@bplb Pushed as commit 209d87a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the Unsafe-allocateMemory-8324960 branch February 7, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants