-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8325042: remove unused JVMDITools test files #17650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into |
@kimbarrett To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label hotspot-runtime |
@kimbarrett |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for removing these. This is a trivial change.
@kimbarrett This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks for review, @coleenp |
/integrate |
Going to push as commit 0cc8e5b.
Your commit was automatically rebased without conflicts. |
@kimbarrett Pushed as commit 0cc8e5b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this trivial change to remove some unused files.
Testing: mach5 tier1
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17650/head:pull/17650
$ git checkout pull/17650
Update a local copy of the PR:
$ git checkout pull/17650
$ git pull https://git.openjdk.org/jdk.git pull/17650/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17650
View PR using the GUI difftool:
$ git pr show -t 17650
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17650.diff
Webrev
Link to Webrev Comment