8325082: Rename headers named 'heapRegion*' of G1

[LizBing]

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8325082: Rename headers named 'heapRegion*' of G1 (Enhancement - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer) ⚠️ Review applies to 7d105a58
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17666/head:pull/17666
$ git checkout pull/17666

Update a local copy of the PR:
$ git checkout pull/17666
$ git pull https://git.openjdk.org/jdk.git pull/17666/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17666

View PR using the GUI difftool:
$ git pr show -t 17666

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17666.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back LizBing! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@LizBing The following labels will be automatically applied to this pull request:

• graal
• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (11628202)
• 03: Full - Incremental (faa6f661)
• 02: Full - Incremental (d65b6597)
• 01: Full - Incremental (7d105a58)
• 00: Full (2d38a1b7)

[stefank]

Looks good to me. There's just a few sort-order issues that needs to be fixed. Please, wait for one of the G1 devs to also review the patch.

[openjdk]

@LizBing This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325082: Rename headers named 'heapRegion*' of G1

Reviewed-by: stefank, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 283 new commits pushed to the master branch:

• 5d414da: 8325372: Shenandoah: SIGSEGV crash in unnecessary_acquire due to LoadStore split through phi
• 93a2e77: 8326129: Java Record Pattern Match leads to infinite loop
• 336bbbe: 8139457: Relax alignment of array elements
• cb809f8: 8325215: Incorrect not exhaustive switch error
• c4409ea: 8325994: JFR: Examples in JFR.start help use incorrect separator
• 54f09d7: 8278527: java/util/concurrent/tck/JSR166TestCase.java fails nanoTime test
• 00ffc42: 8318761: MessageFormat pattern support for CompactNumberFormat, ListFormat, and DateTimeFormatter
• d695af8: 8326376: java -version failed with CONF=fastdebug -XX:InitialCodeCacheSize=1024K -XX:ReservedCodeCacheSize=1200k
• 9f9a732: 8325752: Remove badMetaWordVal
• 864cf22: 8325742: Remove MetaWord usage from MemRegion
• ... and 273 more: https://git.openjdk.org/jdk/compare/432756b6e51c903e2bff8b9c3028a4f2ea8973f4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@stefank, @tschatzl) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[albertnetymk]

/label add hotspot-gc

[openjdk]

@albertnetymk
The hotspot-gc label was successfully added.

[albertnetymk]

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/g1/HeapRegion.java and related files should be updated as well.

[LizBing]

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/g1/HeapRegion.java and related files should be updated as well.

I think we should let the cpp part go first. Could you please tell me the relationship between 'jdk.hotspot.agent' and the source files of hotspot?

[albertnetymk]

Could you please tell me the relationship between 'jdk.hotspot.agent' and the source files of hotspot?

I overlooked that this PR does only file renaming -- class names stay the same. The change inside jdk.hotspot.agent should be reverted for this PR. (They should be done along with the class renaming, e.g. HeapRegion -> G1HeapRegion.) Sorry for the confusion.

[openjdk]

@LizBing Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[LizBing]

thanks for the review.
/integrate

[openjdk]

@LizBing
Your change (at version d65b659) is now ready to be sponsored by a Committer.

[tschatzl]

/sponsor

[openjdk]

Going to push as commit c5f1dcc.
Since your change was applied there have been 314 commits pushed to the master branch:

• 4d82ea1: 8325144: C1: Optimize CriticalEdgeFinder
• a48f596: 8322179: RISC-V: Implement SHA-1 intrinsic
• 5daf63b: 8326636: Problem list StartupOutput.java due to 8326615
• 97aca09: 8326717: Disable stringop-overflow in shenandoahLock.cpp
• ec9437d: 8325247: Memory leak in SessionKeyRef class def when using PKCS11 security provider
• 0901ded: 8326433: Make file-local functions static in src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c
• d22d890: 8325898: ChoiceFormat returns erroneous result when formatting bad pattern
• 93feda3: 8322962: Upcall stub might go undetected when freezing frames
• fc67c2b: 8325530: Vague error message when com.sun.tools.attach.VirtualMachine fails to load agent library
• b87d9cf: 8325506: Ensure randomness is only read from provided SecureRandom object
• ... and 304 more: https://git.openjdk.org/jdk/compare/432756b6e51c903e2bff8b9c3028a4f2ea8973f4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl @LizBing Pushed as commit c5f1dcc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.