8325134: Serial: Remove Generation::used_region

[albertnetymk]

Trivial removing dead code. The change of moving the definition to tenuredGeneration.hpp is needed to work around linking failure.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8325134: Serial: Remove Generation::used_region (Enhancement - P4)

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17673/head:pull/17673
$ git checkout pull/17673

Update a local copy of the PR:
$ git checkout pull/17673
$ git pull https://git.openjdk.org/jdk.git pull/17673/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17673

View PR using the GUI difftool:
$ git pr show -t 17673

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17673.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (12b31e68)
• 00: Full (7c281dcc)

[tschatzl]

This move requires inclusion of space.hpp.

Maybe it is better to move save_used_region() into the .inline.hpp file as well and include the .inline.hpp file where needed.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325134: Serial: Remove Generation::used_region

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• 0377f1a: 8325133: Missing MEMFLAGS parameter in parts of os API
• df35462: 8323502: javac crash with wrongly typed method block in Flow
• af32262: 8325049: stubGenerator_ppc.cpp should use alignas
• 85e3201: 8325159: C2 SuperWord: measure time for CITime
• 8796f43: 8315762: Update subtype check profile collection on s390x following 8308869
• 80642dd: 8324817: Parallel GC does not pre-touch all heap pages when AlwaysPreTouch enabled and large page disabled
• 692c9f8: 8325201: (zipfs) Disable TestPosix.setPermissionsShouldConvertToUnix which fails on Windows
• ed06846: 8325037: x86: enable and fix hotspot/jtreg/compiler/vectorization/TestRoundVectFloat.java
• a18b03b: 8324635: (zipfs) Regression in Files.setPosixFilePermissions called on existing MSDOS entries
• 7476e29: 8323680: SA PointerFinder code can do a better job of leveraging existing code to determine if an address is in the TLAB
• ... and 17 more: https://git.openjdk.org/jdk/compare/6b84f9bb3ee4362bf9daa4fb3905b168f9035336...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

Thanks for review.

/integrate

[openjdk]

Going to push as commit cdf918b.
Since your change was applied there have been 28 commits pushed to the master branch:

• 4da28b4: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test
• 0377f1a: 8325133: Missing MEMFLAGS parameter in parts of os API
• df35462: 8323502: javac crash with wrongly typed method block in Flow
• af32262: 8325049: stubGenerator_ppc.cpp should use alignas
• 85e3201: 8325159: C2 SuperWord: measure time for CITime
• 8796f43: 8315762: Update subtype check profile collection on s390x following 8308869
• 80642dd: 8324817: Parallel GC does not pre-touch all heap pages when AlwaysPreTouch enabled and large page disabled
• 692c9f8: 8325201: (zipfs) Disable TestPosix.setPermissionsShouldConvertToUnix which fails on Windows
• ed06846: 8325037: x86: enable and fix hotspot/jtreg/compiler/vectorization/TestRoundVectFloat.java
• a18b03b: 8324635: (zipfs) Regression in Files.setPosixFilePermissions called on existing MSDOS entries
• ... and 18 more: https://git.openjdk.org/jdk/compare/6b84f9bb3ee4362bf9daa4fb3905b168f9035336...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit cdf918b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.