8316992: Potential null pointer from get_current_thread JVMCI helper function.

[dougxc]

Refactors some JVMCI C++ code that leads a static analysis tool to think a nullptr can be passed to Atomic::PlatformStore<4ull>::operator()<int>.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8316992: Potential null pointer from get_current_thread JVMCI helper function. (Bug - P4)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17676/head:pull/17676
$ git checkout pull/17676

Update a local copy of the PR:
$ git checkout pull/17676
$ git pull https://git.openjdk.org/jdk.git pull/17676/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17676

View PR using the GUI difftool:
$ git pr show -t 17676

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17676.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[TobiHartmann]

Looks good and trivial.

[mlbridge]

Webrevs

• 00: Full (c7d4c23d)

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316992: Potential null pointer from get_current_thread JVMCI helper function.

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

• d1c8215: 8325194: GHA: Add macOS M1 testing
• f356970: 8322535: Change default AArch64 SpinPause instruction
• b75c134: 8325313: Header format error in TestIntrinsicBailOut after JDK-8317299
• 4cd3187: 8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers
• b02599d: 8298046: Fix hidden but significant trailing whitespace in properties files for serviceability code
• 6d911f6: 8317299: safepoint scalarization doesn't keep track of the depth of the JVM state
• 542b0b6: 8324126: Error message for mistyping -XX:+Unlock...Options is not helpful
• 9ee9f28: 8325213: Flags introduced by configure script are not passed to ADLC build
• 729ae1d: 8325266: Enable this-escape javac warning in jdk.javadoc
• e0fd3f4: 8325081: Move '_soft_ref_policy' to 'CollectedHeap'
• ... and 38 more: https://git.openjdk.org/jdk/compare/6b09a79d64bcb1aa5382e60d1d690d4e4a9dc337...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dougxc]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit fd89b33.
Since your change was applied there have been 48 commits pushed to the master branch:

• d1c8215: 8325194: GHA: Add macOS M1 testing
• f356970: 8322535: Change default AArch64 SpinPause instruction
• b75c134: 8325313: Header format error in TestIntrinsicBailOut after JDK-8317299
• 4cd3187: 8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers
• b02599d: 8298046: Fix hidden but significant trailing whitespace in properties files for serviceability code
• 6d911f6: 8317299: safepoint scalarization doesn't keep track of the depth of the JVM state
• 542b0b6: 8324126: Error message for mistyping -XX:+Unlock...Options is not helpful
• 9ee9f28: 8325213: Flags introduced by configure script are not passed to ADLC build
• 729ae1d: 8325266: Enable this-escape javac warning in jdk.javadoc
• e0fd3f4: 8325081: Move '_soft_ref_policy' to 'CollectedHeap'
• ... and 38 more: https://git.openjdk.org/jdk/compare/6b09a79d64bcb1aa5382e60d1d690d4e4a9dc337...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit fd89b33.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.