8325199: (zipfs) jdk/nio/zipfs/TestPosix.java failed 6 sub-tests

[eirbjo]

Please review this PR which fixes an intermittent failure on Windows for the TestPosix test.

The recently introduced test setPermissionsShouldConvertToUnix fails to close the FileSystem returned by createEmptyZipFile. The solution is to move this call within the 'try-with-resources' statement, ensuring it gets properly closed.

Besides fixing the underlying file resource management issue, this PR also re-enables this test on Windows.

Since the author failed to realize that the method createEmptyZipFile returns an open FileSystem, this PR also suggests that we rename this method to createEmptyZipFileSystem in the hope that it will reduce future confusion.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8325199: (zipfs) jdk/nio/zipfs/TestPosix.java failed 6 sub-tests (Bug - P3)

Reviewers

• Christoph Langer (@RealCLanger - Reviewer)
• Lance Andersen (@LanceAndersen - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17702/head:pull/17702
$ git checkout pull/17702

Update a local copy of the PR:
$ git checkout pull/17702
$ git pull https://git.openjdk.org/jdk.git pull/17702/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17702

View PR using the GUI difftool:
$ git pr show -t 17702

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17702.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back eirbjo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@eirbjo The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3998a99f)

[RealCLanger]

Looks good. Thanks for fixing the test.

[openjdk]

@eirbjo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325199: (zipfs) jdk/nio/zipfs/TestPosix.java failed 6 sub-tests

Reviewed-by: clanger, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 55c1446: 8321468: Remove StringUTF16::equals
• 19e9220: 8325169: Reduce String::indexOf overheads
• 89e6a02: 8325064: C2 SuperWord: refactor construct_bb
• d395ac2: 8321373: Build should use LC_ALL=C.UTF-8
• 51671c0: 8323809: Serial: Refactor card table verification
• cdf918b: 8325134: Serial: Remove Generation::used_region
• 4da28b4: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test
• 0377f1a: 8325133: Missing MEMFLAGS parameter in parts of os API
• df35462: 8323502: javac crash with wrongly typed method block in Flow
• af32262: 8325049: stubGenerator_ppc.cpp should use alignas
• ... and 3 more: https://git.openjdk.org/jdk/compare/692c9f8821e220560927dd6bbedfea9ddfe312f6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[LanceAndersen]

Thank you for the update Eirik, the changes look good.

I pulled the changes over and kicked off an internal Mach5 run. Will let you know once it finishes

[LanceAndersen]

Mach 5 run of tier2 was clean as was a run of the test 300 times on windows in a separate mach 5 run

So I think we are good to go with the push of this PR

[eirbjo]

/integrate

[openjdk]

Going to push as commit c3adc61.
Since your change was applied there have been 14 commits pushed to the master branch:

• 1993652: 8324983: race in CompileBroker::possibly_add_compiler_threads
• 55c1446: 8321468: Remove StringUTF16::equals
• 19e9220: 8325169: Reduce String::indexOf overheads
• 89e6a02: 8325064: C2 SuperWord: refactor construct_bb
• d395ac2: 8321373: Build should use LC_ALL=C.UTF-8
• 51671c0: 8323809: Serial: Refactor card table verification
• cdf918b: 8325134: Serial: Remove Generation::used_region
• 4da28b4: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test
• 0377f1a: 8325133: Missing MEMFLAGS parameter in parts of os API
• df35462: 8323502: javac crash with wrongly typed method block in Flow
• ... and 4 more: https://git.openjdk.org/jdk/compare/692c9f8821e220560927dd6bbedfea9ddfe312f6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@eirbjo Pushed as commit c3adc61.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.