Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325213: Flags introduced by configure script are not passed to ADLC build #17705

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Feb 5, 2024

A trivial ADLC build fix. The ADLC_LANGSTD_CXXFLAGS should get passed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8325213: Flags introduced by configure script are not passed to ADLC build (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17705/head:pull/17705
$ git checkout pull/17705

Update a local copy of the PR:
$ git checkout pull/17705
$ git pull https://git.openjdk.org/jdk.git pull/17705/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17705

View PR using the GUI difftool:
$ git pr show -t 17705

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17705.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 5, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 5, 2024
@openjdk
Copy link

openjdk bot commented Feb 5, 2024

@TheRealMDoerr The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Feb 5, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 5, 2024

Webrevs

Copy link
Member

@magicus magicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@openjdk
Copy link

openjdk bot commented Feb 5, 2024

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325213: Flags introduced by configure script are not passed to ADLC build

Reviewed-by: jwaters, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • df35462: 8323502: javac crash with wrongly typed method block in Flow

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 5, 2024
@TheRealMDoerr
Copy link
Contributor Author

Thanks for the reviews!
/integrate

@openjdk
Copy link

openjdk bot commented Feb 6, 2024

Going to push as commit 9ee9f28.
Since your change was applied there have been 20 commits pushed to the master branch:

  • 729ae1d: 8325266: Enable this-escape javac warning in jdk.javadoc
  • e0fd3f4: 8325081: Move '_soft_ref_policy' to 'CollectedHeap'
  • f1f9398: 8323699: MessageFormat.toPattern() generates non-equivalent MessageFormat pattern
  • ab3b941: 8325270: ProblemList two compiler/intrinsics/float16 tests that fail due to JDK-8324724
  • f31957e: 8317636: Improve heap walking API tests to verify correctness of field indexes
  • fd3042a: 8318566: Heap walking functions should not use FilteredFieldStream
  • 209d87a: 8324960: Unsafe.allocateMemory documentation incorrect regarding zero return value
  • 7777eb5: 8321931: memory_swap_current_in_bytes reports 0 as "unlimited"
  • 51853f7: 8324724: Add Stub routines for FP16 conversions on aarch64
  • c3adc61: 8325199: (zipfs) jdk/nio/zipfs/TestPosix.java failed 6 sub-tests
  • ... and 10 more: https://git.openjdk.org/jdk/compare/af32262c28f6dd012307c249156d909bb891e75b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 6, 2024
@openjdk openjdk bot closed this Feb 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 6, 2024
@openjdk
Copy link

openjdk bot commented Feb 6, 2024

@TheRealMDoerr Pushed as commit 9ee9f28.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8325213_ADLD_build branch February 6, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants