Skip to content

Conversation

@albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Feb 5, 2024

Simple obsoletion of a jvm flag.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8325222 to be approved

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17707/head:pull/17707
$ git checkout pull/17707

Update a local copy of the PR:
$ git checkout pull/17707
$ git pull https://git.openjdk.org/jdk.git pull/17707/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17707

View PR using the GUI difftool:
$ git pr show -t 17707

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17707.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 5, 2024

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8325221 8325221: Obsolete TLABStats Feb 5, 2024
@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Feb 5, 2024
@openjdk
Copy link

openjdk bot commented Feb 5, 2024

@albertnetymk The following labels will be automatically applied to this pull request:

  • graal
  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels Feb 5, 2024
@albertnetymk
Copy link
Member Author

/label add hotspot-gc

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Feb 5, 2024
@openjdk
Copy link

openjdk bot commented Feb 5, 2024

@albertnetymk
The hotspot-gc label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Feb 5, 2024

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@openjdk
Copy link

openjdk bot commented Feb 6, 2024

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325221: Obsolete TLABStats

Reviewed-by: tschatzl, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • 0f5f3c9: 8325254: CKA_TOKEN private and secret keys are not necessarily sensitive
  • 4b1e367: 8325152: Clarify specification of java.io.RandomAccessFile.setLength
  • 96eb039: 8324665: Loose matching of space separators in the lenient date/time parsing mode
  • 2d252ee: 8325180: Rename jvmti_FollowRefObjects.h
  • b814c31: 8321703: jdeps generates illegal dot file containing nodesep=0,500000
  • 50b17d9: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers
  • 51d7169: 8320237: C2: late inlining of method handle invoke causes duplicate lines in PrintInlining output
  • fd89b33: 8316992: Potential null pointer from get_current_thread JVMCI helper function.
  • d1c8215: 8325194: GHA: Add macOS M1 testing
  • f356970: 8322535: Change default AArch64 SpinPause instruction
  • ... and 22 more: https://git.openjdk.org/jdk/compare/cdf918b1d0838839254f058b69ef5bf363bdc196...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Feb 6, 2024
Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@albertnetymk
Copy link
Member Author

Thanks for review.

/integrate

@openjdk
Copy link

openjdk bot commented Feb 7, 2024

Going to push as commit 77ee7f0.
Since your change was applied there have been 37 commits pushed to the master branch:

  • 4abb10e: 8317349: Randomize order of macro node expansion in C2
  • 3bffe22: 8319463: ClassSignature should have superclass and superinterfaces as ClassTypeSig
  • e0d98dd: 8325257: jshell reports NoSuchFieldError with instanceof primitive type
  • f2f6344: 8325347: Rename native_thread.h
  • 1797efd: 8322218: Better escaping of single and double quotes in annotation toString() results
  • 0f5f3c9: 8325254: CKA_TOKEN private and secret keys are not necessarily sensitive
  • 4b1e367: 8325152: Clarify specification of java.io.RandomAccessFile.setLength
  • 96eb039: 8324665: Loose matching of space separators in the lenient date/time parsing mode
  • 2d252ee: 8325180: Rename jvmti_FollowRefObjects.h
  • b814c31: 8321703: jdeps generates illegal dot file containing nodesep=0,500000
  • ... and 27 more: https://git.openjdk.org/jdk/compare/cdf918b1d0838839254f058b69ef5bf363bdc196...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 7, 2024
@openjdk openjdk bot closed this Feb 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 7, 2024
@openjdk
Copy link

openjdk bot commented Feb 7, 2024

@albertnetymk Pushed as commit 77ee7f0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the obsolete branch February 7, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graal graal-dev@openjdk.org hotspot hotspot-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants