8321703: jdeps generates illegal dot file containing nodesep=0,500000

[mlchung]

Trivial fix. Call PrintWriter::format with null Locale to format with no localization.

This PR also fixes JDK-8325262 to print FindException message without the stack trace to indicate clearer that the given module path is incorrect.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8321703: jdeps generates illegal dot file containing nodesep=0,500000 (Bug - P4)
• JDK-8325262: jdeps can drop printing stack trace when FindException is thrown due to modules not found (Enhancement - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17713/head:pull/17713
$ git checkout pull/17713

Update a local copy of the PR:
$ git checkout pull/17713
$ git pull https://git.openjdk.org/jdk.git pull/17713/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17713

View PR using the GUI difftool:
$ git pr show -t 17713

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17713.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mlchung The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlchung]

/issue add JDK-8325262

[openjdk]

@mlchung
Adding additional issue to issue list: 8325262: jdeps can drop printing stack trace when FindException is thrown due to modules not found.

[mlbridge]

Webrevs

• 00: Full (9a39c1ae)

[jaikiran]

Hello Mandy, the changes look OK to me.

[openjdk]

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321703: jdeps generates illegal dot file containing nodesep=0,500000
8325262: jdeps can drop printing stack trace when FindException is thrown due to modules not found

Reviewed-by: jpai, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 542b0b6: 8324126: Error message for mistyping -XX:+Unlock...Options is not helpful
• 9ee9f28: 8325213: Flags introduced by configure script are not passed to ADLC build
• 729ae1d: 8325266: Enable this-escape javac warning in jdk.javadoc
• e0fd3f4: 8325081: Move '_soft_ref_policy' to 'CollectedHeap'
• f1f9398: 8323699: MessageFormat.toPattern() generates non-equivalent MessageFormat pattern
• ab3b941: 8325270: ProblemList two compiler/intrinsics/float16 tests that fail due to JDK-8324724
• f31957e: 8317636: Improve heap walking API tests to verify correctness of field indexes
• fd3042a: 8318566: Heap walking functions should not use FilteredFieldStream
• 209d87a: 8324960: Unsafe.allocateMemory documentation incorrect regarding zero return value
• 7777eb5: 8321931: memory_swap_current_in_bytes reports 0 as "unlimited"
• ... and 1 more: https://git.openjdk.org/jdk/compare/c3adc61e6ed4114908dd42ab3d43ad6482a5a9b0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[AlanBateman]

Looks okay. (JDK-8325262 should probably be changed to be Bug rather than Enhancement)

[mlchung]

Thanks for the review.

[mlchung]

/integrate

[openjdk]

Going to push as commit b814c31.
Since your change was applied there have been 20 commits pushed to the master branch:

• 50b17d9: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers
• 51d7169: 8320237: C2: late inlining of method handle invoke causes duplicate lines in PrintInlining output
• fd89b33: 8316992: Potential null pointer from get_current_thread JVMCI helper function.
• d1c8215: 8325194: GHA: Add macOS M1 testing
• f356970: 8322535: Change default AArch64 SpinPause instruction
• b75c134: 8325313: Header format error in TestIntrinsicBailOut after JDK-8317299
• 4cd3187: 8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers
• b02599d: 8298046: Fix hidden but significant trailing whitespace in properties files for serviceability code
• 6d911f6: 8317299: safepoint scalarization doesn't keep track of the depth of the JVM state
• 542b0b6: 8324126: Error message for mistyping -XX:+Unlock...Options is not helpful
• ... and 10 more: https://git.openjdk.org/jdk/compare/c3adc61e6ed4114908dd42ab3d43ad6482a5a9b0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mlchung Pushed as commit b814c31.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.