Skip to content

8317368: [JVMCI] SIGSEGV in JVMCIEnv::initialize_installed_code on libgraal #17714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
+88 −22
Closed

8317368: [JVMCI] SIGSEGV in JVMCIEnv::initialize_installed_code on libgraal #17714

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
58d14ef
8317368: [JVMCI] SIGSEGV in JVMCIEnv::initialize_installed_code on li…
tkrodriguez Feb 5, 2024
8c76ec9
Move BarrierSetNMethod call into JVMCINMethodHandle::set_nmethod
tkrodriguez Feb 5, 2024
429a769
Merge branch 'master' into tkr-nmethod-keep-alive
tkrodriguez Feb 6, 2024
2a2142f
Comment updates
tkrodriguez Feb 6, 2024
3d2417e
Merge branch 'master' into tkr-nmethod-keep-alive
tkrodriguez Apr 15, 2024
a047272
Update some comments
tkrodriguez Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotspot/share/jvmci/jvmciEnv.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ class JVMCIEnv : public ResourceObj {

void fthrow_error(const char* file, int line, const char* format, ...) ATTRIBUTE_PRINTF(4, 5);

// Given an instance of HotSpotInstalledCode return the corresponding CodeBlob*.
// Given an instance of HotSpotInstalledCode, return the corresponding CodeBlob*.
CodeBlob* get_code_blob(JVMCIObject code);

// Given an instance of HotSpotInstalledCode return the corresponding nmethod.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please improve the comment while here, adding a , after HotSpotInstalledCode.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Expand Down
3 changes: 2 additions & 1 deletion src/hotspot/share/runtime/javaThread.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,8 @@ class JavaThread: public Thread {
jlong _jvmci_reserved1;
oop _jvmci_reserved_oop0;

// This field is used to keep an nmethod visible to the GC so that it can be kept alive
// This field is used to keep an nmethod visible to the GC so that it and its contained oops can
// be kept alive
nmethod* _live_nmethod;

public:
Expand Down