Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8236225: Remove expired flags in JDK 17 #1773

Closed
wants to merge 6 commits into from

Conversation

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Dec 14, 2020

8236225: Remove expired flags in JDK 17
8256717: Expire the long term obsoleted VM flags

The newly expired flags in 17 are removed from the flag table, as are all of the long term obsolete flags that had no explicit expiration release.

Updated any remaining references to the obsolete flags that are now expired.

Updated the man page to move flags from obsolete section to expired (removed) section. Note the manpage also shows changes to the illegal-access flag, this is a change that was made to the closed manpage source for JDK 16 but has not yet been pushed into the open java.1 version. This part of the change can be ignored.

Testing: tiers 1-3 and local testing of modified tests. I'm also checking for any JCK tests that may still use the legacy obsolete flags.

Thanks,
David


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1773/head:pull/1773
$ git checkout pull/1773

@dholmes-ora
Copy link
Member Author

@dholmes-ora dholmes-ora commented Dec 14, 2020

/issue add JDK-8256717

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 14, 2020

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Dec 14, 2020

@dholmes-ora
Adding additional issue to issue list: 8256717: Expire the long term obsoleted VM flags.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Dec 14, 2020

@dholmes-ora The following labels will be automatically applied to this pull request:

  • build
  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@dholmes-ora
Copy link
Member Author

@dholmes-ora dholmes-ora commented Dec 14, 2020

/label remove build

Loading

@openjdk openjdk bot removed the build label Dec 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 14, 2020

@dholmes-ora
The build label was successfully removed.

Loading

@dholmes-ora dholmes-ora marked this pull request as ready for review Dec 14, 2020
@openjdk openjdk bot added the rfr label Dec 14, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 14, 2020

Webrevs

Loading

Copy link
Contributor

@coleenp coleenp left a comment

LGTM!

Loading

src/hotspot/share/runtime/arguments.cpp Show resolved Hide resolved
Loading
@openjdk
Copy link

@openjdk openjdk bot commented Dec 14, 2020

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8236225: Remove expired flags in JDK 17
8256717: Expire the long term obsoleted VM flags

Reviewed-by: coleenp, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 2c3ae19: 8258239: Shenandoah: Used wrong closure to mark concurrent roots
  • 1ff0f16: 8258142: Simplify G1RedirtyCardsQueue
  • e8c40ba: 8255880: UI of Swing components is not redrawn after their internal state changed
  • 1548104: 8255477: Remove unused method URL.set(String protocol, String host, int port, String file, String ref)
  • e69ae07: 8257985: count_trailing_zeros doesn't handle 64-bit values on 32-bit JVM
  • 2ee795d: 8196092: javax/swing/JComboBox/8032878/bug8032878.java fails
  • c30fff7: 8257229: gtest death tests fail with unrecognized stderr output

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Dec 14, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 15, 2020

Mailing list message from David Holmes on hotspot-runtime-dev:

On 15/12/2020 9:53 am, Vladimir Kozlov wrote:

On Mon, 14 Dec 2020 22:43:16 GMT, David Holmes <dholmes at openjdk.org> wrote:

8236225: Remove expired flags in JDK 17
8256717: Expire the long term obsoleted VM flags

The newly expired flags in 17 are removed from the flag table, as are all of the long term obsolete flags that had no explicit expiration release.

Updated any remaining references to the obsolete flags that are now expired.

Updated the man page to move flags from obsolete section to expired (removed) section. Note the manpage also shows changes to the illegal-access flag, this is a change that was made to the closed manpage source for JDK 16 but has not yet been pushed into the open java.1 version. This part of the change can be ignored.

Testing: tiers 1-3 and local testing of modified tests. I'm also checking for any JCK tests that may still use the legacy obsolete flags.

Thanks,
David

Marked as reviewed by kvn (Reviewer).

Thanks Vladimir!

David

Loading

@dholmes-ora
Copy link
Member Author

@dholmes-ora dholmes-ora commented Dec 15, 2020

/integrate

Loading

@openjdk openjdk bot closed this Dec 16, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 16, 2020

@dholmes-ora Since your change was applied there have been 32 commits pushed to the master branch:

  • 4d6f318: 8257726: Make -XX:+StressLdcRewrite option a diagnostic option
  • 8bf46c7: 8258438: build error in test/hotspot/gtest/runtime/test_os.cpp
  • 7977e38: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image
  • c37eabe: 8252148: vmError::controlled_crash should be #ifdef ASSERT and move tests to gtest
  • 2273f95: 8234930: Use MAP_JIT when allocating pages for code cache on macOS
  • da2415f: 8257457: Update --release 16 symbol information for JDK 16 build 28
  • 36e2097: 8255917: runtime/cds/SharedBaseAddress.java failed "assert(reserved_rgn != 0LL) failed: No reserved region"
  • d53ee62: 8255899: Allow uninstallation of jpackage exe bundles
  • 65756ab: 8257802: LogCompilation throws couldn't find bytecode on JDK 8 log
  • a372be4: 8258244: Shenandoah: Not expecting forwarded object in roots during mark after JDK-8240868
  • ... and 22 more: https://git.openjdk.java.net/jdk/compare/e1182920db658a1999c00f315623c48776e52c13...master

Your commit was automatically rebased without conflicts.

Pushed as commit 1e77896.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@dholmes-ora dholmes-ora deleted the flag-update-17 branch Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants