JDK-8325432: enhance assert message "relocation addr must be in this section"

[MBaesken]

The assert message "relocation addr must be in this section" in codeBuffer.hpp could be enhanced by printing the pointer and section information.
See also
https://bugs.openjdk.org/browse/JDK-8325326
8325326: compiler/codecache/TestStressCodeBuffers.java assertion on AIX

where we run into the assertion since 2 days.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8325432: enhance assert message "relocation addr must be in this section" (Enhancement - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17749/head:pull/17749
$ git checkout pull/17749

Update a local copy of the PR:
$ git checkout pull/17749
$ git pull https://git.openjdk.org/jdk.git pull/17749/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17749

View PR using the GUI difftool:
$ git pr show -t 17749

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17749.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (84852ef9)

[vnkozlov]

Good.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325432: enhance assert message "relocation addr must be in this section"

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 43089bf: 8325399: Add tests for virtual threads doing Selector operations
• d109903: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread
• 1fb9e3d: 8325304: Several classes in java.util.jar and java.util.zip don't specify the behaviour for null arguments
• 9cccf05: 8325367: Rename nsk_list.h
• be7cc1c: 8323681: SA PointerFinder code should support G1
• fbd15b2: 8325189: Enable this-escape javac warning in java.base
• 299a8ee: 8325302: Files.move(REPLACE_EXISTING) throws NoSuchFileException on deleted target
• 3a1f4d0: 8325268: Add policy statement to langtools makefiles concerning warnings
• 18e24d0: 8325109: Sort method modifiers in canonical order
• a3a2b1f: 8324881: ObjectSynchronizer::inflate(Thread* current...) is invoked for non-current thread
• ... and 2 more: https://git.openjdk.org/jdk/compare/c3a632dca75d2fad0a60e03e7b4fc64edb1e906e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Looks good.

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit 3d3a8f0.
Since your change was applied there have been 14 commits pushed to the master branch:

• b58d73b: 8323746: Add PathElement hashCode and equals
• 917838e: 8325150: (tz) Update Timezone Data to 2024a
• 43089bf: 8325399: Add tests for virtual threads doing Selector operations
• d109903: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread
• 1fb9e3d: 8325304: Several classes in java.util.jar and java.util.zip don't specify the behaviour for null arguments
• 9cccf05: 8325367: Rename nsk_list.h
• be7cc1c: 8323681: SA PointerFinder code should support G1
• fbd15b2: 8325189: Enable this-escape javac warning in java.base
• 299a8ee: 8325302: Files.move(REPLACE_EXISTING) throws NoSuchFileException on deleted target
• 3a1f4d0: 8325268: Add policy statement to langtools makefiles concerning warnings
• ... and 4 more: https://git.openjdk.org/jdk/compare/c3a632dca75d2fad0a60e03e7b4fc64edb1e906e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 3d3a8f0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.