Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325367: Rename nsk_list.h #17758

Closed
wants to merge 1 commit into from
Closed

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Feb 7, 2024

Please review this trivial change that renames the file
test/hotspot/jtreg/vmTestbase/nsk/share/native/nsk_list.h to nsk_list.hpp.

Testing: mach5 tier1
Note that build would fail if #include updates were incorrect or incomplete.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17758/head:pull/17758
$ git checkout pull/17758

Update a local copy of the PR:
$ git checkout pull/17758
$ git pull https://git.openjdk.org/jdk.git pull/17758/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17758

View PR using the GUI difftool:
$ git pr show -t 17758

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17758.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 7, 2024

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 7, 2024
@openjdk
Copy link

openjdk bot commented Feb 7, 2024

@kimbarrett The following labels will be automatically applied to this pull request:

  • hotspot-runtime
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org labels Feb 7, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 7, 2024

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's trivial.

@openjdk
Copy link

openjdk bot commented Feb 7, 2024

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325367: Rename nsk_list.h

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • fbd15b2: 8325189: Enable this-escape javac warning in java.base
  • 299a8ee: 8325302: Files.move(REPLACE_EXISTING) throws NoSuchFileException on deleted target
  • 3a1f4d0: 8325268: Add policy statement to langtools makefiles concerning warnings
  • 18e24d0: 8325109: Sort method modifiers in canonical order
  • a3a2b1f: 8324881: ObjectSynchronizer::inflate(Thread* current...) is invoked for non-current thread
  • a9c6e87: 8325416: Parallel: Refactor CheckForUnmarkedOops
  • 1ecf74c: 8325306: Rename static huge pages to explicit huge pages
  • c3a632d: 8325248: Serial: Remove Generation::space_iterate
  • 77ee7f0: 8325221: Obsolete TLABStats
  • 4abb10e: 8317349: Randomize order of macro node expansion in C2
  • ... and 2 more: https://git.openjdk.org/jdk/compare/f2f634448e2095f2be1c220d7c10355ab4888439...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 7, 2024
@kimbarrett
Copy link
Author

Thanks for review, @coleenp

@kimbarrett
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 8, 2024

Going to push as commit 9cccf05.
Since your change was applied there have been 13 commits pushed to the master branch:

  • be7cc1c: 8323681: SA PointerFinder code should support G1
  • fbd15b2: 8325189: Enable this-escape javac warning in java.base
  • 299a8ee: 8325302: Files.move(REPLACE_EXISTING) throws NoSuchFileException on deleted target
  • 3a1f4d0: 8325268: Add policy statement to langtools makefiles concerning warnings
  • 18e24d0: 8325109: Sort method modifiers in canonical order
  • a3a2b1f: 8324881: ObjectSynchronizer::inflate(Thread* current...) is invoked for non-current thread
  • a9c6e87: 8325416: Parallel: Refactor CheckForUnmarkedOops
  • 1ecf74c: 8325306: Rename static huge pages to explicit huge pages
  • c3a632d: 8325248: Serial: Remove Generation::space_iterate
  • 77ee7f0: 8325221: Obsolete TLABStats
  • ... and 3 more: https://git.openjdk.org/jdk/compare/f2f634448e2095f2be1c220d7c10355ab4888439...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 8, 2024
@openjdk openjdk bot closed this Feb 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 8, 2024
@openjdk
Copy link

openjdk bot commented Feb 8, 2024

@kimbarrett Pushed as commit 9cccf05.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the nsk_list branch February 8, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants