8258252: Move PtrQueue enqueue to PtrQueueSet subclasses

[kimbarrett]

Please review this refactoring in the PtrQueue/PtrQueueSet hierarchy.

The functions PtrQueue::enqueue and PtrQueue::enqueue_known_active are
removed, along with the helper virtual function PtrQueue::handle_completed_buffer.

Instead we now have G1{Dirty,Redirty}CardQueueSet::enqueue and SATBMarkQueueSet::enqueue/enqueue_known_active, each tailored to the corresponding specific behavior. They use some shared helper routines from PtrQueueSet, and the PtrQueue buffer and index have been made accessible to clients.

Testing:
mach5 tier1-3, 5 (stress tests)
Local (linux-x64) tier1 with -XX:+UseShenandoahGC

/label hotspot

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8258252: Move PtrQueue enqueue to PtrQueueSet subclasses

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer) ⚠️ Review applies to 9dc2a4e
• Roman Kennke (@rkennke - Reviewer) ⚠️ Review applies to 9dc2a4e

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1776/head:pull/1776
$ git checkout pull/1776

[bridgekeeper]

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kimbarrett
The hotspot label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (6cfd4be)
• 00: Full (9dc2a4e)

[tschatzl]

Lgtm.

[openjdk]

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258252: Move PtrQueue enqueue to PtrQueueSet subclasses

Reviewed-by: tschatzl, rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[rkennke]

Looks good to me, and I ran some more Shenandoah tests which also look good.

[kimbarrett]

Thanks @tschatzl and @rkennke for reviews, and @rkennke for additional Shenandoah testing.

[kimbarrett]

/integrate

[openjdk]

@kimbarrett Pushed as commit cdb5342.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.