Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8325470: [AIX] use fclose after fopen in read_psinfo #17769

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Feb 8, 2024

There seems to be a missing fclose after fopen in read_psinfo (os_perf_aix.cpp).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8325470: [AIX] use fclose after fopen in read_psinfo (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17769/head:pull/17769
$ git checkout pull/17769

Update a local copy of the PR:
$ git checkout pull/17769
$ git pull https://git.openjdk.org/jdk.git pull/17769/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17769

View PR using the GUI difftool:
$ git pr show -t 17769

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17769.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 8, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 8, 2024
@openjdk
Copy link

openjdk bot commented Feb 8, 2024

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Feb 8, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 8, 2024

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Feb 8, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325470: [AIX] use fclose after fopen in read_psinfo

Reviewed-by: mdoerr, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 10beb31: 8325456: Rename nsk_mutex.h
  • 0ea75b2: 8325259: Serial: Inline OldGenScanClosure during Young GC
  • ab5e947: 8325436: G1: Remove unused G1RegionMarkStats::is_clear
  • 3c91b59: 8325444: GHA: JDK-8325194 causes a regression
  • e8ceb71: 6507038: Memory Leak in JTree / BasicTreeUI
  • 3d3a8f0: 8325432: enhance assert message "relocation addr must be in this section"
  • b58d73b: 8323746: Add PathElement hashCode and equals
  • 917838e: 8325150: (tz) Update Timezone Data to 2024a

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 8, 2024
Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MBaesken
Copy link
Member Author

/integrate

@MBaesken
Copy link
Member Author

Hi Kim and Martin, thanks for the reviews !

@openjdk
Copy link

openjdk bot commented Feb 13, 2024

Going to push as commit 4513da9.
Since your change was applied there have been 51 commits pushed to the master branch:

  • 62a4be0: 8325635: Serial: Inline verify_used_region_at_save_marks
  • b356fee: 8325458: Rename mlvmJvmtiUtils.h
  • 2ed889b: 8323628: Update license on "pass-through" files
  • 7c69712: 8325570: Update to Graphviz 9.0.0
  • 482c100: 8322865: JavaDoc fails on aggregator modules
  • b3e0587: 8322874: Redirection loop in index.html
  • d70156d: 8325529: Remove unused imports from ModuleGenerator test file
  • 4628763: 8320302: compiler/arguments/TestC1Globals.java hits SIGSEGV in ContinuationEntry::set_enter_code
  • 1e4b701: 8316931: [macos14] Test "java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.html" throws an exception on macOS 14(x64, aarch64)
  • 16b3be0: 8325503: Add GC specific prefix for CheckForUnmarked related classes
  • ... and 41 more: https://git.openjdk.org/jdk/compare/43089bf0065ce85681724d92d26709f4e3ad28ea...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 13, 2024
@openjdk openjdk bot closed this Feb 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 13, 2024
@openjdk
Copy link

openjdk bot commented Feb 13, 2024

@MBaesken Pushed as commit 4513da9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants