8325516: Shenandoah: Move heap change tracking into ShenandoahHeap

[earthling-amzn]

Shenandoah sets a flag when new regions are allocated or retired. This flag currently resides in the control thread. Moving it into the heap reduces code duplication with upcoming generational mode changes.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8325516: Shenandoah: Move heap change tracking into ShenandoahHeap (Task - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Kelvin Nilsen (@kdnilsen - no project role) ⚠️ Review applies to e4b5ed74
• Y. Srinivas Ramakrishna (@ysramakrishna - Reviewer) ⚠️ Review applies to e4b5ed74

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17777/head:pull/17777
$ git checkout pull/17777

Update a local copy of the PR:
$ git checkout pull/17777
$ git pull https://git.openjdk.org/jdk.git pull/17777/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17777

View PR using the GUI difftool:
$ git pr show -t 17777

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17777.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@earthling-amzn The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (9208bbba)
• 01: Full - Incremental (e4b5ed74)
• 00: Full (c2654552)

[shipilev]

The move looks good, but I think it introduces a bug.

[ysramakrishna]

LGTM; good cleanup! Minor doc suggestion.

[openjdk]

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325516: Shenandoah: Move heap change tracking into ShenandoahHeap

Reviewed-by: shade, kdnilsen, ysr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 8d9ad97: 8324641: [IR Framework] Add Setup method to provide custom arguments and set fields
• b797652: 8322927: Unused code in LIR_Assembler::verify_oop_map
• 9936aee: 8324824: AArch64: Detect Ampere-1B core and update default options for Ampere CPUs
• d91fb17: 8325505: Fix Javadoc ResourceBundle::getString

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @ysramakrishna) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[earthling-amzn]

/integrate

[openjdk]

@earthling-amzn
Your change (at version 9208bbb) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit cc276ff.
Since your change was applied there have been 4 commits pushed to the master branch:

• 8d9ad97: 8324641: [IR Framework] Add Setup method to provide custom arguments and set fields
• b797652: 8322927: Unused code in LIR_Assembler::verify_oop_map
• 9936aee: 8324824: AArch64: Detect Ampere-1B core and update default options for Ampere CPUs
• d91fb17: 8325505: Fix Javadoc ResourceBundle::getString

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @earthling-amzn Pushed as commit cc276ff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.