8325517: Shenandoah: Reduce unnecessary includes from shenandoahControlThread.cpp

[earthling-amzn]

The control thread used to run much more of the cycle directly. This code was all factored out into different classes, but many of the vestigial headers remained. Removing these improves compilation times and makes maintenance easier.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8325517: Shenandoah: Reduce unnecessary includes from shenandoahControlThread.cpp (Task - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Kelvin Nilsen (@kdnilsen - no project role) ⚠️ Review applies to fd24ad00
• Y. Srinivas Ramakrishna (@ysramakrishna - Reviewer) ⚠️ Review applies to fd24ad00

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17778/head:pull/17778
$ git checkout pull/17778

Update a local copy of the PR:
$ git checkout pull/17778
$ git pull https://git.openjdk.org/jdk.git pull/17778/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17778

View PR using the GUI difftool:
$ git pr show -t 17778

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17778.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@earthling-amzn The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (52272b90)
• 01: Full - Incremental (5212e221)
• 00: Full (fd24ad00)

[shipilev]

Looks generally okay. The usual rule of thumb is to see if any symbols from the include are actually used in the compilation unit. If used, keep the explicit header. Check this? At least one case is obvious from reading the code, see below.

Note that build might still succeed without the explicit header due to transitive header dependencies, but it is fragile and would yield build failures later.

[earthling-amzn]

I only removed a couple of headers that were obviously not needed directly in the control thread (I think there are a couple more I can trim). I didn't try to find and declare all the direct/first-level dependencies (log.hpp, for example).

[ysramakrishna]

Looks good modulo Aleksey's suggestion on checking use of header file's content in compilation unit rather than relying on serendipitous (and fragile) transitive dependencies.

[openjdk]

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325517: Shenandoah: Reduce unnecessary includes from shenandoahControlThread.cpp

Reviewed-by: shade, kdnilsen, ysr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 40708ba: 8325563: Remove unused Space::is_in
• 29d89d4: 8325551: Remove unused obj_is_alive and block_start in Space
• 8ef918d: 8324646: Avoid Class.forName in SecureRandom constructor
• 69b2674: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG
• 52d4976: 8325437: Safepoint polling in monitor deflation can cause massive logs
• 8b70b8d: 8325440: Confusing error reported for octal literals with wrong digits
• 5daf622: 8325309: Amend "Listeners and Threads" in AWTThreadIssues.html
• d165d12: 8325510: Serial: Remove redundant arg in non_clean_card_iterate
• 71b46c3: 8325471: CHeapBitMap(MEMFLAGS flags) constructor misleading use of super-constructor
• e3dc6a7: 8314275: Incorrect stepping in switch
• ... and 5 more: https://git.openjdk.org/jdk/compare/10beb3184e14e2714cd836029680a8b2d3fd5011...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @ysramakrishna) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[earthling-amzn]

/integrate

[openjdk]

@earthling-amzn
Your change (at version 52272b9) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 4a3a38d.
Since your change was applied there have been 15 commits pushed to the master branch:

• 40708ba: 8325563: Remove unused Space::is_in
• 29d89d4: 8325551: Remove unused obj_is_alive and block_start in Space
• 8ef918d: 8324646: Avoid Class.forName in SecureRandom constructor
• 69b2674: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG
• 52d4976: 8325437: Safepoint polling in monitor deflation can cause massive logs
• 8b70b8d: 8325440: Confusing error reported for octal literals with wrong digits
• 5daf622: 8325309: Amend "Listeners and Threads" in AWTThreadIssues.html
• d165d12: 8325510: Serial: Remove redundant arg in non_clean_card_iterate
• 71b46c3: 8325471: CHeapBitMap(MEMFLAGS flags) constructor misleading use of super-constructor
• e3dc6a7: 8314275: Incorrect stepping in switch
• ... and 5 more: https://git.openjdk.org/jdk/compare/10beb3184e14e2714cd836029680a8b2d3fd5011...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @earthling-amzn Pushed as commit 4a3a38d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.