Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325203: System.exit(0) kills the launched 3rd party application #17779

Closed

Conversation

alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Feb 8, 2024

Tested with the use case from the CR.

The idea of the fix is to prevent grandchildren processes from being automatically attached to the job killing all processes attached to it when the job object is destroyed.

Filed a follow-up https://bugs.openjdk.org/browse/JDK-8325525 CR to track adding a jtreg test for the issue.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8325203: System.exit(0) kills the launched 3rd party application (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17779/head:pull/17779
$ git checkout pull/17779

Update a local copy of the PR:
$ git checkout pull/17779
$ git pull https://git.openjdk.org/jdk.git pull/17779/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17779

View PR using the GUI difftool:
$ git pr show -t 17779

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17779.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 8, 2024

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 8, 2024
@openjdk
Copy link

openjdk bot commented Feb 8, 2024

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 8, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 8, 2024

Webrevs

@alexeysemenyukoracle
Copy link
Member Author

@sashamatveev please review

Copy link
Member

@sashamatveev sashamatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Feb 8, 2024

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325203: System.exit(0) kills the launched 3rd party application

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 9936aee: 8324824: AArch64: Detect Ampere-1B core and update default options for Ampere CPUs
  • d91fb17: 8325505: Fix Javadoc ResourceBundle::getString

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 8, 2024
@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 9, 2024

Going to push as commit 6944537.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 4368437: 8325264: two compiler/intrinsics/float16 tests fail after JDK-8324724
  • 4a3a38d: 8325517: Shenandoah: Reduce unnecessary includes from shenandoahControlThread.cpp
  • 40708ba: 8325563: Remove unused Space::is_in
  • 29d89d4: 8325551: Remove unused obj_is_alive and block_start in Space
  • 8ef918d: 8324646: Avoid Class.forName in SecureRandom constructor
  • 69b2674: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG
  • 52d4976: 8325437: Safepoint polling in monitor deflation can cause massive logs
  • 8b70b8d: 8325440: Confusing error reported for octal literals with wrong digits
  • 5daf622: 8325309: Amend "Listeners and Threads" in AWTThreadIssues.html
  • d165d12: 8325510: Serial: Remove redundant arg in non_clean_card_iterate
  • ... and 7 more: https://git.openjdk.org/jdk/compare/10beb3184e14e2714cd836029680a8b2d3fd5011...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 9, 2024
@openjdk openjdk bot closed this Feb 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 9, 2024
@openjdk
Copy link

openjdk bot commented Feb 9, 2024

@alexeysemenyukoracle Pushed as commit 6944537.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sblantipodi
Copy link

sblantipodi commented Mar 5, 2024

Hi @sblantipodi, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user sblantipodi" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants