8319578: Few java/lang/instrument ignore test.java.opts and accept test.vm.opts only

[lmesnik]

There are several .sh tests which use ${TESTVMOPTS} only. Updated them to use ${TESTJAVAOPTS} also.
Tested by running them with different options and tier1.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8319578: Few java/lang/instrument ignore test.java.opts and accept test.vm.opts only (Sub-task - P5)

Reviewers

• Kevin Walls (@kevinjwalls - Reviewer)
• Chris Plummer (@plummercj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17780/head:pull/17780
$ git checkout pull/17780

Update a local copy of the PR:
$ git checkout pull/17780
$ git pull https://git.openjdk.org/jdk.git pull/17780/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17780

View PR using the GUI difftool:
$ git pr show -t 17780

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17780.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lmesnik The following labels will be automatically applied to this pull request:

• core-libs
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (dff45604)

[lmesnik]

/label remove core-libs

[openjdk]

@lmesnik
The core-libs label was successfully removed.

[AlanBateman]

/label remove core-libs

[openjdk]

@AlanBateman The core-libs label was not set.

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319578: Few java/lang/instrument ignore test.java.opts and accept test.vm.opts only

Reviewed-by: kevinw, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

• 6944537: 8325203: System.exit(0) kills the launched 3rd party application
• 4368437: 8325264: two compiler/intrinsics/float16 tests fail after JDK-8324724
• 4a3a38d: 8325517: Shenandoah: Reduce unnecessary includes from shenandoahControlThread.cpp
• 40708ba: 8325563: Remove unused Space::is_in
• 29d89d4: 8325551: Remove unused obj_is_alive and block_start in Space
• 8ef918d: 8324646: Avoid Class.forName in SecureRandom constructor
• 69b2674: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG
• 52d4976: 8325437: Safepoint polling in monitor deflation can cause massive logs
• 8b70b8d: 8325440: Confusing error reported for octal literals with wrong digits
• 5daf622: 8325309: Amend "Listeners and Threads" in AWTThreadIssues.html
• ... and 35 more: https://git.openjdk.org/jdk/compare/0f5f3c9b9718c610406088327401210486447462...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[plummercj]

The changes look fine. What testing have you done? Would be good to test with options like -Xcomp and different GCs. which are probably the options most likely to impact these tests. Maybe JFR also.

[lmesnik]

/integrate
@kevinjwalls, @plummercj Thank you for review.
I run tests with all options used for testing.

[openjdk]

Going to push as commit 3ebe6c1.
Since your change was applied there have been 48 commits pushed to the master branch:

• d39b7ba: 8316460: 4 javax/management tests ignore VM flags
• ac4607e: 8226919: attach in linux hangs due to permission denied accessing /proc/pid/root
• b42b888: 8325038: runtime/cds/appcds/ProhibitedPackage.java can fail with UseLargePages
• 6944537: 8325203: System.exit(0) kills the launched 3rd party application
• 4368437: 8325264: two compiler/intrinsics/float16 tests fail after JDK-8324724
• 4a3a38d: 8325517: Shenandoah: Reduce unnecessary includes from shenandoahControlThread.cpp
• 40708ba: 8325563: Remove unused Space::is_in
• 29d89d4: 8325551: Remove unused obj_is_alive and block_start in Space
• 8ef918d: 8324646: Avoid Class.forName in SecureRandom constructor
• 69b2674: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG
• ... and 38 more: https://git.openjdk.org/jdk/compare/0f5f3c9b9718c610406088327401210486447462...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lmesnik Pushed as commit 3ebe6c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.