Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316451: 6 java/lang/instrument/PremainClass tests ignore VM flags #17781

Closed
wants to merge 1 commit into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Feb 8, 2024

Tests updated to use jtreg vm flags.
Tested by running tests with different flags and tier1.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316451: 6 java/lang/instrument/PremainClass tests ignore VM flags (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17781/head:pull/17781
$ git checkout pull/17781

Update a local copy of the PR:
$ git checkout pull/17781
$ git pull https://git.openjdk.org/jdk.git pull/17781/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17781

View PR using the GUI difftool:
$ git pr show -t 17781

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17781.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 8, 2024

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 8, 2024
@openjdk
Copy link

openjdk bot commented Feb 8, 2024

@lmesnik The following labels will be automatically applied to this pull request:

  • core-libs
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Feb 8, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 8, 2024

Webrevs

@lmesnik
Copy link
Member Author

lmesnik commented Feb 9, 2024

/label remove core-libs

@openjdk openjdk bot removed the core-libs core-libs-dev@openjdk.org label Feb 9, 2024
@openjdk
Copy link

openjdk bot commented Feb 9, 2024

@lmesnik
The core-libs label was successfully removed.

@AlanBateman
Copy link
Contributor

/label remove core-libs

@openjdk
Copy link

openjdk bot commented Feb 9, 2024

@AlanBateman The core-libs label was not set.

Copy link
Contributor

@plummercj plummercj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Feb 15, 2024

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316451: 6 java/lang/instrument/PremainClass tests ignore VM flags

Reviewed-by: cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 120 new commits pushed to the master branch:

  • 0fdfdf7: 8325983: Build failure after JDK-8324580
  • 3b1062d: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane
  • 5a988a5: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • a231706: 8324580: SIGFPE on THP initialization on kernels < 4.10
  • 2564f0f: 8325906: Problemlist vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java#id1 until JDK-8320865 is fixed
  • 9a1b843: 8324584: Optimize Symbol and char* handling in ClassLoader
  • a0e5e16: 8325162: Remove duplicate GCMParameters class
  • 0d51b76: 8325877: Split up NativeCompilation.gmk
  • 2b1a840: 8325860: Serial: Move Generation.java to serial folder
  • b718ae3: 8325882: Serial: Move is_maximal_no_gc to TenuredGeneration
  • ... and 110 more: https://git.openjdk.org/jdk/compare/0f5f3c9b9718c610406088327401210486447462...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 15, 2024
@lmesnik
Copy link
Member Author

lmesnik commented Feb 15, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Feb 15, 2024

Going to push as commit 9029bf6.
Since your change was applied there have been 121 commits pushed to the master branch:

  • 99c9ae1: 8323664: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java still fails with JNI warning on some Windows configurations
  • 0fdfdf7: 8325983: Build failure after JDK-8324580
  • 3b1062d: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane
  • 5a988a5: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • a231706: 8324580: SIGFPE on THP initialization on kernels < 4.10
  • 2564f0f: 8325906: Problemlist vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java#id1 until JDK-8320865 is fixed
  • 9a1b843: 8324584: Optimize Symbol and char* handling in ClassLoader
  • a0e5e16: 8325162: Remove duplicate GCMParameters class
  • 0d51b76: 8325877: Split up NativeCompilation.gmk
  • 2b1a840: 8325860: Serial: Move Generation.java to serial folder
  • ... and 111 more: https://git.openjdk.org/jdk/compare/0f5f3c9b9718c610406088327401210486447462...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 15, 2024
@openjdk openjdk bot closed this Feb 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 15, 2024
@openjdk
Copy link

openjdk bot commented Feb 15, 2024

@lmesnik Pushed as commit 9029bf6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

4 participants