Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8325529: Remove unused imports from ModuleGenerator test file #17782

Conversation

jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Feb 8, 2024

Please review an automated update to fix the imports in the test sampleapi package.

While only one file was affected in a sibling PR, it seems that all the files in the package had disorganized imports. While low priority, fixing them here will stop the issue showing up in other PRs.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8325529: Remove unused imports from ModuleGenerator test file (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17782/head:pull/17782
$ git checkout pull/17782

Update a local copy of the PR:
$ git checkout pull/17782
$ git pull https://git.openjdk.org/jdk.git pull/17782/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17782

View PR using the GUI difftool:
$ git pr show -t 17782

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17782.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 8, 2024

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 8, 2024
@openjdk
Copy link

openjdk bot commented Feb 8, 2024

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label Feb 8, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 8, 2024

Webrevs

@jonathan-gibbons jonathan-gibbons changed the title JDK-8325529: Remove unused imports from ModuleGenerator test file. JDK-8325529: Remove unused imports from ModuleGenerator test file Feb 9, 2024
@openjdk
Copy link

openjdk bot commented Feb 12, 2024

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325529: Remove unused imports from `ModuleGenerator` test file

Reviewed-by: prappo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • 16b3be0: 8325503: Add GC specific prefix for CheckForUnmarked related classes
  • 1358850: 8322694: C1: Handle Constant and IfOp in NullCheckEliminator
  • 6a12362: 8325606: compiler/predicates/TestPredicatesBasic.java does not compile
  • e5cb78c: 8324539: Do not use LFS64 symbols in JDK libs
  • efa071d: 8323089: networkaddress.cache.ttl is not a system property
  • 2546afe: 8325451: Missed elimination of assertion predicates
  • af7eeff: 8325565: Remove unused SpaceClosure
  • 232d136: 8324890: C2 SuperWord: refactor out VLoop, make unrolling_analysis static, remove init/reset mechanism
  • 71d2dbd: 8325464: GCCause.java out of sync with gcCause.hpp
  • 6c7029f: 8318603: Parallelize sun/java2d/marlin/ClipShapeTest.java
  • ... and 22 more: https://git.openjdk.org/jdk/compare/9936aeea32b71509151099e6d28905e0322b2bc2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 12, 2024
@jonathan-gibbons
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 12, 2024

Going to push as commit d70156d.
Since your change was applied there have been 34 commits pushed to the master branch:

  • 4628763: 8320302: compiler/arguments/TestC1Globals.java hits SIGSEGV in ContinuationEntry::set_enter_code
  • 1e4b701: 8316931: [macos14] Test "java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.html" throws an exception on macOS 14(x64, aarch64)
  • 16b3be0: 8325503: Add GC specific prefix for CheckForUnmarked related classes
  • 1358850: 8322694: C1: Handle Constant and IfOp in NullCheckEliminator
  • 6a12362: 8325606: compiler/predicates/TestPredicatesBasic.java does not compile
  • e5cb78c: 8324539: Do not use LFS64 symbols in JDK libs
  • efa071d: 8323089: networkaddress.cache.ttl is not a system property
  • 2546afe: 8325451: Missed elimination of assertion predicates
  • af7eeff: 8325565: Remove unused SpaceClosure
  • 232d136: 8324890: C2 SuperWord: refactor out VLoop, make unrolling_analysis static, remove init/reset mechanism
  • ... and 24 more: https://git.openjdk.org/jdk/compare/9936aeea32b71509151099e6d28905e0322b2bc2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 12, 2024
@openjdk openjdk bot closed this Feb 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 12, 2024
@openjdk
Copy link

openjdk bot commented Feb 12, 2024

@jonathan-gibbons Pushed as commit d70156d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jonathan-gibbons jonathan-gibbons deleted the 8325529.ModuleGenerator-unused-imports branch February 12, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants