-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8325529: Remove unused imports from ModuleGenerator
test file
#17782
JDK-8325529: Remove unused imports from ModuleGenerator
test file
#17782
Conversation
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
@jonathan-gibbons The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
ModuleGenerator
test file.ModuleGenerator
test file
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 32 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit d70156d.
Your commit was automatically rebased without conflicts. |
@jonathan-gibbons Pushed as commit d70156d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review an automated update to fix the imports in the test
sampleapi
package.While only one file was affected in a sibling PR, it seems that all the files in the package had disorganized imports. While low priority, fixing them here will stop the issue showing up in other PRs.
Progress
Issue
ModuleGenerator
test file (Bug - P4)Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17782/head:pull/17782
$ git checkout pull/17782
Update a local copy of the PR:
$ git checkout pull/17782
$ git pull https://git.openjdk.org/jdk.git pull/17782/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17782
View PR using the GUI difftool:
$ git pr show -t 17782
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17782.diff
Webrev
Link to Webrev Comment