8325382: (fc) FileChannel.transferTo throws IOException when position equals size

[bplb]

In FileChannelImpl.transferTo, do not clamp the number of bytes to transfer to the number remaining in the source FileChannel unless the size of the source is positive. When clamping, do not use the strict inequality remaining > 0, but rather allow clamping to zero.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8325382: (fc) FileChannel.transferTo throws IOException when position equals size (Bug - P3)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17796/head:pull/17796
$ git checkout pull/17796

Update a local copy of the PR:
$ git checkout pull/17796
$ git pull https://git.openjdk.org/jdk.git pull/17796/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17796

View PR using the GUI difftool:
$ git pr show -t 17796

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17796.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (ecd01954)
• 00: Full (40370a4f)

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325382: (fc) FileChannel.transferTo throws IOException when position equals size

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 61 new commits pushed to the master branch:

• c266800: 8325558: Add jcheck whitespace checking for properties files
• ec20b0a: 8325626: Allow selection of non-matching configurations using CONF=!string
• 618af39: 8325633: Use stricter assertion in callers of Space::is_aligned
• 5dbf137: 8319797: Recursive lightweight locking: Runtime implementation
• 4513da9: 8325470: [AIX] use fclose after fopen in read_psinfo
• 62a4be0: 8325635: Serial: Inline verify_used_region_at_save_marks
• b356fee: 8325458: Rename mlvmJvmtiUtils.h
• 2ed889b: 8323628: Update license on "pass-through" files
• 7c69712: 8325570: Update to Graphviz 9.0.0
• 482c100: 8322865: JavaDoc fails on aggregator modules
• ... and 51 more: https://git.openjdk.org/jdk/compare/fbd15b20878b276ccd41128116f73b91b6d4c159...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

/integrate

[openjdk]

Going to push as commit 6b7c971.
Since your change was applied there have been 69 commits pushed to the master branch:

• 13d9e8f: 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906
• 57b04e1: 8325748: Serial: Move Generation::promote to TenuredGeneration
• 7cd25ed: 8322854: Incorrect rematerialization of scalar replaced objects in C2
• 7ec2bad: 8323520: Drop unnecessary virtual specifier in Space
• 71ff2d7: 8325616: JFR ZGC Allocation Stall events should record stack traces
• c3c1cdd: 8325731: Installation instructions for Debian/Ubuntu don't mention autoconf
• f8d8eec: 8325325: Breadcrumb navigation shows preview link for modules and packages
• 088e54f: 8325650: Table of contents scroll timeout not long enough
• c266800: 8325558: Add jcheck whitespace checking for properties files
• ec20b0a: 8325626: Allow selection of non-matching configurations using CONF=!string
• ... and 59 more: https://git.openjdk.org/jdk/compare/fbd15b20878b276ccd41128116f73b91b6d4c159...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 6b7c971.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.