-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8325606: compiler/predicates/TestPredicatesBasic.java does not compile #17801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TobiHartmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial.
|
👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into |
|
@chhagedorn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@chhagedorn The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
Thanks Tobias for the quick review! /integrate |
|
@chhagedorn Pushed as commit 6a12362. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The newly added test fails because #17557 went in shortly before which changed the required format for
@Arguments. This patch fixes this.Tested locally.
Thanks,
Christian
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17801/head:pull/17801$ git checkout pull/17801Update a local copy of the PR:
$ git checkout pull/17801$ git pull https://git.openjdk.org/jdk.git pull/17801/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17801View PR using the GUI difftool:
$ git pr show -t 17801Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17801.diff
Webrev
Link to Webrev Comment