Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325653: Erroneous exhaustivity analysis for primitive patterns #17810

Closed
wants to merge 2 commits into from

Conversation

biboudis
Copy link
Member

@biboudis biboudis commented Feb 12, 2024

This PR fixes an exhaustivity analysis issue with primitive patterns, that was implementing the clause in 14.11.1.1 erroneously (in the case where the selector is a reference type).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8325653: Erroneous exhaustivity analysis for primitive patterns (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17810/head:pull/17810
$ git checkout pull/17810

Update a local copy of the PR:
$ git checkout pull/17810
$ git pull https://git.openjdk.org/jdk.git pull/17810/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17810

View PR using the GUI difftool:
$ git pr show -t 17810

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17810.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 12, 2024

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 12, 2024
@openjdk
Copy link

openjdk bot commented Feb 12, 2024

@biboudis The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Feb 12, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 12, 2024

Webrevs

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openjdk
Copy link

openjdk bot commented Feb 13, 2024

@biboudis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325653: Erroneous exhaustivity analysis for primitive patterns

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

  • 628cd8a: 8303866: Allow ZipInputStream.readEnd to parse small Zip64 ZIP files
  • 842b895: 8303891: Speed up Zip64SizeTest using a small ZIP64 file
  • 243fb46: 8325750: Fix spelling of ForceTranslateFailure help message
  • 74b90aa: 8325672: C2: allocate PhaseIdealLoop::_loop_or_ctrl from C->comp_arena()
  • 6dfa7f3: 8325541: C2 SuperWord: refactor filter / split
  • 6b7c971: 8325382: (fc) FileChannel.transferTo throws IOException when position equals size
  • 13d9e8f: 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906
  • 57b04e1: 8325748: Serial: Move Generation::promote to TenuredGeneration
  • 7cd25ed: 8322854: Incorrect rematerialization of scalar replaced objects in C2
  • 7ec2bad: 8323520: Drop unnecessary virtual specifier in Space
  • ... and 18 more: https://git.openjdk.org/jdk/compare/16b3be0a76b0a71c8f59168dfc94c06d8a899bd4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 13, 2024
@biboudis
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 14, 2024

Going to push as commit 0c2def0.
Since your change was applied there have been 33 commits pushed to the master branch:

  • d003996: 8325743: test/jdk/java/nio/channels/unixdomain/SocketOptions.java enhance user name output in error case
  • ea98de6: 8325449: [BACKOUT] use "dmb.ishst+dmb.ishld" for release barrier
  • 7f6bb71: 8319799: Recursive lightweight locking: x86 implementation
  • ea41932: 8325395: Missing copyright header in StackFilter.java
  • 8765b17: 8325800: Drop unused cups declaration from Oracle build configuration
  • 628cd8a: 8303866: Allow ZipInputStream.readEnd to parse small Zip64 ZIP files
  • 842b895: 8303891: Speed up Zip64SizeTest using a small ZIP64 file
  • 243fb46: 8325750: Fix spelling of ForceTranslateFailure help message
  • 74b90aa: 8325672: C2: allocate PhaseIdealLoop::_loop_or_ctrl from C->comp_arena()
  • 6dfa7f3: 8325541: C2 SuperWord: refactor filter / split
  • ... and 23 more: https://git.openjdk.org/jdk/compare/16b3be0a76b0a71c8f59168dfc94c06d8a899bd4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 14, 2024
@openjdk openjdk bot closed this Feb 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 14, 2024
@openjdk
Copy link

openjdk bot commented Feb 14, 2024

@biboudis Pushed as commit 0c2def0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants