-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8325650: Table of contents scroll timeout not long enough #17811
Conversation
👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into |
@hns This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 34 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 088e54f.
Your commit was automatically rebased without conflicts. |
Please review a simple change to increase a timeout value for suppression of scroll-following in the table of contents. This should have no visible effects to the user but may avoid flickering of the table of contents on slower computers. I also replaced a normal inequality operator (
!=
) with a strict one (!==
) which is better practice when comparing equal types.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17811/head:pull/17811
$ git checkout pull/17811
Update a local copy of the PR:
$ git checkout pull/17811
$ git pull https://git.openjdk.org/jdk.git pull/17811/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17811
View PR using the GUI difftool:
$ git pr show -t 17811
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17811.diff
Webrev
Link to Webrev Comment