Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8325650: Table of contents scroll timeout not long enough #17811

Closed
wants to merge 1 commit into from

Conversation

hns
Copy link
Member

@hns hns commented Feb 12, 2024

Please review a simple change to increase a timeout value for suppression of scroll-following in the table of contents. This should have no visible effects to the user but may avoid flickering of the table of contents on slower computers. I also replaced a normal inequality operator (!=) with a strict one (!==) which is better practice when comparing equal types.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8325650: Table of contents scroll timeout not long enough (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17811/head:pull/17811
$ git checkout pull/17811

Update a local copy of the PR:
$ git checkout pull/17811
$ git pull https://git.openjdk.org/jdk.git pull/17811/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17811

View PR using the GUI difftool:
$ git pr show -t 17811

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17811.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 12, 2024

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 12, 2024
@openjdk
Copy link

openjdk bot commented Feb 12, 2024

@hns The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label Feb 12, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 12, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 12, 2024

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325650: Table of contents scroll timeout not long enough

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 12, 2024
@hns
Copy link
Member Author

hns commented Feb 13, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Feb 13, 2024

Going to push as commit 088e54f.
Since your change was applied there have been 34 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 13, 2024
@openjdk openjdk bot closed this Feb 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 13, 2024
@openjdk
Copy link

openjdk bot commented Feb 13, 2024

@hns Pushed as commit 088e54f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants