Skip to content

8325731: Installation instructions for Debian/Ubuntu don't mention autoconf#17826

Closed
parttimenerd wants to merge 1 commit intoopenjdk:masterfrom
parttimenerd:parttimenerd_8325731
Closed

8325731: Installation instructions for Debian/Ubuntu don't mention autoconf#17826
parttimenerd wants to merge 1 commit intoopenjdk:masterfrom
parttimenerd:parttimenerd_8325731

Conversation

@parttimenerd
Copy link
Contributor

@parttimenerd parttimenerd commented Feb 13, 2024

So I added autoconf besides build-essential. With both packages, bash configure is runnable.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8325731: Installation instructions for Debian/Ubuntu don't mention autoconf (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17826/head:pull/17826
$ git checkout pull/17826

Update a local copy of the PR:
$ git checkout pull/17826
$ git pull https://git.openjdk.org/jdk.git pull/17826/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17826

View PR using the GUI difftool:
$ git pr show -t 17826

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17826.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 13, 2024

👋 Welcome back jbechberger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 13, 2024
@openjdk
Copy link

openjdk bot commented Feb 13, 2024

@parttimenerd The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Feb 13, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 13, 2024

Webrevs

Copy link
Member

@magicus magicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@openjdk
Copy link

openjdk bot commented Feb 13, 2024

@parttimenerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325731: Installation instructions for Debian/Ubuntu don't mention autoconf

Reviewed-by: ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • f8d8eec: 8325325: Breadcrumb navigation shows preview link for modules and packages

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 13, 2024
@parttimenerd
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 13, 2024

Going to push as commit c3c1cdd.
Since your change was applied there has been 1 commit pushed to the master branch:

  • f8d8eec: 8325325: Breadcrumb navigation shows preview link for modules and packages

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 13, 2024
@openjdk openjdk bot closed this Feb 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 13, 2024
@openjdk
Copy link

openjdk bot commented Feb 13, 2024

@parttimenerd Pushed as commit c3c1cdd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@parttimenerd
Copy link
Contributor Author

/backport jdk21u-dev

@openjdk
Copy link

openjdk bot commented Sep 11, 2025

@parttimenerd the backport was successfully created on the branch backport-parttimenerd-c3c1cdd1-master in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit c3c1cdd1 from the openjdk/jdk repository.

The commit being backported was authored by Johannes Bechberger on 13 Feb 2024 and was reviewed by Magnus Ihse Bursie.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-parttimenerd-c3c1cdd1-master:backport-parttimenerd-c3c1cdd1-master
$ git checkout backport-parttimenerd-c3c1cdd1-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-parttimenerd-c3c1cdd1-master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants