8257726: Make -XX:+StressLdcRewrite option a diagnostic option

[coleenp]

See bug for details. Tested:

$ java -XX:+StressLdcRewrite -version
Error: VM option 'StressLdcRewrite' is diagnostic and must be enabled via -XX:+UnlockDiagnosticVMOptions.
Error: The unlock option must precede 'StressLdcRewrite'.
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
$ java -XX:+UnlockDiagnosticVMOptions -XX:+StressLdcRewrite -version
openjdk version "16-internal" 2021-03-16
OpenJDK Runtime Environment (build 16-internal+0-2020-12-15-1356558.coleen...)
OpenJDK 64-Bit Server VM (build 16-internal+0-2020-12-15-1356558.coleen..., mixed mode, sharing)

Also, java/lang/instrument which has a test using StressLdcRewrite and tier1.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8257726: Make -XX:+StressLdcRewrite option a diagnostic option

Reviewers

• Lois Foltan (@lfoltan - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)
• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1783/head:pull/1783
$ git checkout pull/1783

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following labels will be automatically applied to this pull request:

• core-libs
• hotspot-runtime
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b1a3ae9)

[AlanBateman]

/label remove core-libs

[openjdk]

@AlanBateman
The core-libs label was successfully removed.

[lfoltan]

Looks good Coleen.
Lois

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257726: Make -XX:+StressLdcRewrite option a diagnostic option

Reviewed-by: lfoltan, stuefe, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 8bf46c7: 8258438: build error in test/hotspot/gtest/runtime/test_os.cpp
• 7977e38: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image
• c37eabe: 8252148: vmError::controlled_crash should be #ifdef ASSERT and move tests to gtest
• 2273f95: 8234930: Use MAP_JIT when allocating pages for code cache on macOS
• da2415f: 8257457: Update --release 16 symbol information for JDK 16 build 28
• 36e2097: 8255917: runtime/cds/SharedBaseAddress.java failed "assert(reserved_rgn != 0LL) failed: No reserved region"
• d53ee62: 8255899: Allow uninstallation of jpackage exe bundles
• 65756ab: 8257802: LogCompilation throws couldn't find bytecode on JDK 8 log

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

Looks right to me, and trivial. This should not be a product option.
I cannot believe anyone uses this option in earnest in production. Still, out of sheer fascination I googled but did not find any serious usage.

[coleenp]

I cannot believe anyone uses this option in earnest in production. Still, out of sheer fascination I googled but did not find any serious usage.
I discussed this with @dcubed-ojdk who added this for a customer situation and this was his request.
Thanks for the code review.
Coleen

[yminqi]

jvmtiRedfineClasses.cpp use it.

[dcubed-ojdk]

Thumbs up!

[coleenp]

Thanks Lois, Thomas and Dan.
/integrate

[openjdk]

@coleenp Since your change was applied there have been 8 commits pushed to the master branch:

• 8bf46c7: 8258438: build error in test/hotspot/gtest/runtime/test_os.cpp
• 7977e38: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image
• c37eabe: 8252148: vmError::controlled_crash should be #ifdef ASSERT and move tests to gtest
• 2273f95: 8234930: Use MAP_JIT when allocating pages for code cache on macOS
• da2415f: 8257457: Update --release 16 symbol information for JDK 16 build 28
• 36e2097: 8255917: runtime/cds/SharedBaseAddress.java failed "assert(reserved_rgn != 0LL) failed: No reserved region"
• d53ee62: 8255899: Allow uninstallation of jpackage exe bundles
• 65756ab: 8257802: LogCompilation throws couldn't find bytecode on JDK 8 log

Your commit was automatically rebased without conflicts.

Pushed as commit 4d6f318.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.