8325748: Serial: Move Generation::promote to TenuredGeneration

[albertnetymk]

Trivial moving a method, and minor doc revision.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8325748: Serial: Move Generation::promote to TenuredGeneration (Enhancement - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17830/head:pull/17830
$ git checkout pull/17830

Update a local copy of the PR:
$ git checkout pull/17830
$ git pull https://git.openjdk.org/jdk.git pull/17830/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17830

View PR using the GUI difftool:
$ git pr show -t 17830

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17830.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (305b8fff)

[stefank]

The move looks fine.

I might have preferred if the transform_stack_chunk were put inside DefNewGeneration::copy_to_survivor_space, which calls transform_stack_chunk for the non-promoted objects. Maybe that could be done as a separate cleanup?

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325748: Serial: Move Generation::promote to TenuredGeneration

Reviewed-by: stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

Maybe that could be done as a separate cleanup?

Sure.

Thanks for review.

/integrate

[openjdk]

Going to push as commit 57b04e1.

[openjdk]

@albertnetymk Pushed as commit 57b04e1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.