Skip to content

Conversation

@dougxc
Copy link
Member

@dougxc dougxc commented Feb 13, 2024

This PR fixes a spelling mistake in the help text for the jvmci.ForceTranslateFailure option.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8325750: Fix spelling of ForceTranslateFailure help message (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17831/head:pull/17831
$ git checkout pull/17831

Update a local copy of the PR:
$ git checkout pull/17831
$ git pull https://git.openjdk.org/jdk.git pull/17831/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17831

View PR using the GUI difftool:
$ git pr show -t 17831

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17831.diff

Webrev

Link to Webrev Comment

@dougxc dougxc marked this pull request as ready for review February 13, 2024 14:29
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 13, 2024

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 13, 2024
@openjdk
Copy link

openjdk bot commented Feb 13, 2024

@dougxc The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Feb 13, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 13, 2024

Webrevs

"of the peer runtime. The value is a filter that can restrict the forced failure to matching translated " +
"objects. See HotSpotJVMCIRuntime.postTranslation for more details. This option exists soley to test " +
"objects. See HotSpotJVMCIRuntime.postTranslation for more details. This option exists solely to test " +
"correct handling of translation failure."),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be plural?

Suggested change
"correct handling of translation failure."),
"correct handling of translation failures."),

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Suggested change applied.

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented Feb 13, 2024

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325750: Fix spelling of ForceTranslateFailure help message

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 13d9e8f: 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906
  • 57b04e1: 8325748: Serial: Move Generation::promote to TenuredGeneration

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 13, 2024
@dougxc
Copy link
Member Author

dougxc commented Feb 13, 2024

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Feb 13, 2024

Going to push as commit 243fb46.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 74b90aa: 8325672: C2: allocate PhaseIdealLoop::_loop_or_ctrl from C->comp_arena()
  • 6dfa7f3: 8325541: C2 SuperWord: refactor filter / split
  • 6b7c971: 8325382: (fc) FileChannel.transferTo throws IOException when position equals size
  • 13d9e8f: 8325590: Regression in round-tripping UTF-16 strings after JDK-8311906
  • 57b04e1: 8325748: Serial: Move Generation::promote to TenuredGeneration

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 13, 2024
@openjdk openjdk bot closed this Feb 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 13, 2024
@openjdk
Copy link

openjdk bot commented Feb 13, 2024

@dougxc Pushed as commit 243fb46.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants