-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8325750: Fix spelling of ForceTranslateFailure help message #17831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into |
Webrevs
|
| "of the peer runtime. The value is a filter that can restrict the forced failure to matching translated " + | ||
| "objects. See HotSpotJVMCIRuntime.postTranslation for more details. This option exists soley to test " + | ||
| "objects. See HotSpotJVMCIRuntime.postTranslation for more details. This option exists solely to test " + | ||
| "correct handling of translation failure."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be plural?
| "correct handling of translation failure."), | |
| "correct handling of translation failures."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Suggested change applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial.
|
@dougxc This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
Thanks for the review. /integrate |
|
Going to push as commit 243fb46.
Your commit was automatically rebased without conflicts. |
This PR fixes a spelling mistake in the help text for the
jvmci.ForceTranslateFailureoption.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17831/head:pull/17831$ git checkout pull/17831Update a local copy of the PR:
$ git checkout pull/17831$ git pull https://git.openjdk.org/jdk.git pull/17831/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17831View PR using the GUI difftool:
$ git pr show -t 17831Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17831.diff
Webrev
Link to Webrev Comment