-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8254850: Update terminology in java.awt.GridBagLayout source code comments #1784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One minor question.
@@ -1364,7 +1364,7 @@ else if (constraints.gridwidth == 0 && curCol < 0) | |||
px = constraints.tempX + constraints.tempWidth; /* right column */ | |||
|
|||
/* | |||
* Figure out if we should use this slave\'s weight. If the weight | |||
* Figure out if we should use this child\'s weight. If the weight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the \
still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for any reason I can imagine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 36 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@prrace Since your change was applied there have been 65 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 9ed0b76. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms.
See JDK-8253315 for details.
This updates a few comments in GridBagLayout to use the terms parent and child which are
sufficiently descriptive and consistent with lots of other usages.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1784/head:pull/1784
$ git checkout pull/1784