-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8258420: Move URL configuration from Docs.gmk to conf dir #1785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay me to but I can't help thinking that javadoc.conf should also be the place to list the root modules for javadoc (PR 1781 puts them in oddly named module-sets-docs.conf).
Maybe, but if anything I think they should rather merge with the upcoming At this stage, I'd like to concentrate on just splitting out the configuration part from the makefiles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay.
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@magicus Since your change was applied there have been 14 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 6eca296. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
In
Docs.gmk
there are some hard-coded links to online URL documentation and bug reporting locations. These should not reside in the make file per se, but instead move to themake/conf
directory.Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1785/head:pull/1785
$ git checkout pull/1785