8325763: Revert properties: vm.opt.x.*

[lkorinth]

Instead of fixing the problems found in 8320750, remove the feature of mapping -X flags to vm.opt.x properties in VMProps.java. After some thought, it seems better to remove the feature than to implement it in a suboptimal way.

Related to #16824.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8325763: Revert properties: vm.opt.x.* (Enhancement - P4)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Stefan Karlsson (@stefank - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17851/head:pull/17851
$ git checkout pull/17851

Update a local copy of the PR:
$ git checkout pull/17851
$ git pull https://git.openjdk.org/jdk.git pull/17851/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17851

View PR using the GUI difftool:
$ git pr show -t 17851

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17851.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lkorinth! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lkorinth The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[lkorinth]

Tested on tier1-3 with no related errors.

[mlbridge]

Webrevs

• 00: Full (ad77da7b)

[openjdk]

@lkorinth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325763: Revert properties: vm.opt.x.*

Reviewed-by: ayang, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

• b823fa4: 8325574: Shenandoah: Simplify and enhance reporting of requested GCs
• 09d4936: 8252136: Several methods in hotspot are missing "static"
• f6e2851: 8316340: (bf) Missing {@inheritdoc} for exception in MappedByteBuffer::compact
• 53878ee: 8325643: G1: Refactor G1FlushHumongousCandidateRemSets
• 130f429: 8325403: Add SystemGC JMH benchmarks
• 9c852df: 8318966: Some methods make promises about Java array element alignment that are too strong
• 737b4c5: 8323883: JFR AssertionError: Missing object ID 15101
• 61f2493: 8325767: Serial: Move transform_stack_chunk out of TenuredGeneration::promote
• 8dc5976: 8325809: JFR: Remove unnecessary annotation
• 84965ea: 8322630: Remove ICStubs and related safepoints
• ... and 35 more: https://git.openjdk.org/jdk/compare/1358850aa63a2874031ca33eba278432fd09d6ab...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lkorinth]

Thanks Stefan and Albert!!!

[lkorinth]

/integrate

[openjdk]

Going to push as commit 0aaec97.
Since your change was applied there have been 67 commits pushed to the master branch:

• 4018b2b: 8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin
• 2705ed0: 8325074: ZGC fails assert(index == 0 || is_power_of_2(index)) failed: Incorrect load shift: 11
• 3d85103: 8316813: NMT: Using WhiteBox API, virtual memory tracking should also be stressed in JMH tests
• ba8db1f: 8325876: crashes in docker container tests on Linuxppc64le Power8 machines
• 18cea82: 8319801: Recursive lightweight locking: aarch64 implementation
• 9029bf6: 8316451: 6 java/lang/instrument/PremainClass tests ignore VM flags
• 99c9ae1: 8323664: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java still fails with JNI warning on some Windows configurations
• 0fdfdf7: 8325983: Build failure after JDK-8324580
• 3b1062d: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane
• 5a988a5: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
• ... and 57 more: https://git.openjdk.org/jdk/compare/1358850aa63a2874031ca33eba278432fd09d6ab...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lkorinth Pushed as commit 0aaec97.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.