Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8325876: crashes in docker container tests on Linuxppc64le Power8 machines #17867

Closed
wants to merge 3 commits into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Feb 15, 2024

We noticed recently crashes in docker container tests on Linuxppc64le Power8 machines. Those tests use 'ubuntu ppc64le latest' for the container.
The crash looks like this :

containers/docker/TestContainerInfo.java

#
# A fatal error has been detected by the Java Runtime Environment:
#
# SIGILL (0x4) at pc=0x00007fffa18cfc50, pid=1, tid=7
#
# JRE version: OpenJDK Runtime Environment (23.0) (fastdebug build 23-internal-adhoc.jenkinsi.jdk)
# Java VM: OpenJDK 64-Bit Server VM (fastdebug 23-internal-adhoc.jenkinsi.jdk, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, serial gc, linux-ppc64le)
# Problematic frame:
# C [libz.so.1+0xfc50] inflateReset+0x60
#
# Core dump will be written. Default location: //core.1
#
# An error report file with more information is saved as:
# //hs_err_pid1.log


However 'ubuntu ppc64le latest' (and even 'ubuntu ppc64le 22.04') does not work any more on Power8 machines.
See https://ubuntu.com/download/server/power : "Starting with Ubuntu 22.04 LTS, POWER9 and POWER10 processors are supported.
The support for POWER8 ends with Ubuntu 21.10, respectively Ubuntu 20.04 LTS, which is still supported for several years."

So we should consider changing the image on Linux ppc64le to avoid unwanted crashes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8325876: crashes in docker container tests on Linuxppc64le Power8 machines (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17867/head:pull/17867
$ git checkout pull/17867

Update a local copy of the PR:
$ git checkout pull/17867
$ git pull https://git.openjdk.org/jdk.git pull/17867/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17867

View PR using the GUI difftool:
$ git pr show -t 17867

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17867.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 15, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 15, 2024
@openjdk
Copy link

openjdk bot commented Feb 15, 2024

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Feb 15, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 15, 2024

Webrevs

@RealCLanger
Copy link
Contributor

Can we somehow determine the power version of the test machine and only return the older Ubuntu version on Power 8? Otherwise I'm concerned that this never gets updated for Power...

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. We still support Power 8.

@openjdk
Copy link

openjdk bot commented Feb 15, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325876: crashes in docker container tests on Linuxppc64le Power8 machines

Reviewed-by: mdoerr, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 18cea82: 8319801: Recursive lightweight locking: aarch64 implementation
  • 9029bf6: 8316451: 6 java/lang/instrument/PremainClass tests ignore VM flags
  • 99c9ae1: 8323664: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java still fails with JNI warning on some Windows configurations
  • 0fdfdf7: 8325983: Build failure after JDK-8324580
  • 3b1062d: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane
  • 5a988a5: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • a231706: 8324580: SIGFPE on THP initialization on kernels < 4.10
  • 2564f0f: 8325906: Problemlist vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java#id1 until JDK-8320865 is fixed
  • 9a1b843: 8324584: Optimize Symbol and char* handling in ClassLoader
  • a0e5e16: 8325162: Remove duplicate GCMParameters class
  • ... and 5 more: https://git.openjdk.org/jdk/compare/1aae980c549741cf5fc5ca51f3c299285bafa49d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 15, 2024
@MBaesken
Copy link
Member Author

Can we somehow determine the power version of the test machine and only return the older Ubuntu version on Power 8? Otherwise I'm concerned that this never gets updated for Power...

We could look at /proc/cpuinfo and grep for POWER8

more /proc/cpuinfo 
processor	: 0
cpu		: POWER8 (architected), altivec supported
clock		: 3525.000000MHz

But I would prefer to keep it simple and always use Ubuntu 20.04 as long as we support Power8 .

@MBaesken
Copy link
Member Author

MBaesken commented Feb 15, 2024

We could also add a comment here

flags-cflags.m4-809-      elif test "x$FLAGS_CPU" = xppc64le; then
flags-cflags.m4-810-        # Little endian machine uses ELFv2 ABI.
flags-cflags.m4-811-        # Use Power8, this is the first CPU to support PPC64 LE with ELFv2 ABI.
flags-cflags.m4:812:        $1_CFLAGS_CPU_JVM="${$1_CFLAGS_CPU_JVM} -DABI_ELFv2 -mcpu=power8 -mtune=power8"

The comment can point to the Ubuntu docker usage and state that we can switch to a higher Ubuntu version once we change the mcpu flag .

@TheRealMDoerr
Copy link
Contributor

Can we somehow determine the power version of the test machine and only return the older Ubuntu version on Power 8? Otherwise I'm concerned that this never gets updated for Power...

We could look at /proc/cpuinfo and grep for POWER8

more /proc/cpuinfo 
processor	: 0
cpu		: POWER8 (architected), altivec supported
clock		: 3525.000000MHz

But I would prefer to keep it simple and always use Ubuntu 20.04 as long as we support Power8 .

The WhiteBox API supports WB.getCPUFeatures(). That could be used, but I'd prefer to keep it simple, too.

@TheRealMDoerr
Copy link
Contributor

We could also add a comment here

flags-cflags.m4-809-      elif test "x$FLAGS_CPU" = xppc64le; then
flags-cflags.m4-810-        # Little endian machine uses ELFv2 ABI.
flags-cflags.m4-811-        # Use Power8, this is the first CPU to support PPC64 LE with ELFv2 ABI.
flags-cflags.m4:812:        $1_CFLAGS_CPU_JVM="${$1_CFLAGS_CPU_JVM} -DABI_ELFv2 -mcpu=power8 -mtune=power8"

The comment can point to the Ubuntu docker usage and state that we can switch to a higher Ubuntu version once we change the mcpu flag .

I guess that somebody will want to use Power 8 longer than IBM supports it. So, we can probably use a newer Ubuntu for supported test machines at some point of time, but not change -mcpu=power8.

@@ -809,6 +809,7 @@ AC_DEFUN([FLAGS_SETUP_CFLAGS_CPU_DEP],
elif test "x$FLAGS_CPU" = xppc64le; then
# Little endian machine uses ELFv2 ABI.
# Use Power8, this is the first CPU to support PPC64 LE with ELFv2 ABI.
# After we switch to Power9+, we can use higher releases than Ubuntu 20.04 in class DockerfileConfig used for container tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, my feeling is that we should not bloat the comments here. Maybe revert this line.

@RealCLanger
Copy link
Contributor

RealCLanger commented Feb 15, 2024

The WhiteBox API supports WB.getCPUFeatures(). That could be used, but I'd prefer to keep it simple, too.

OK, then let's use Ubuntu 20.04 on PPC unconditionally. But we should rather not add the comment in flags-cflags.m4.

@MBaesken
Copy link
Member Author

I removed the comment in flags-cflags.m4.
Thanks for the reviews !

/integrate

@openjdk
Copy link

openjdk bot commented Feb 16, 2024

Going to push as commit ba8db1f.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 18cea82: 8319801: Recursive lightweight locking: aarch64 implementation
  • 9029bf6: 8316451: 6 java/lang/instrument/PremainClass tests ignore VM flags
  • 99c9ae1: 8323664: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java still fails with JNI warning on some Windows configurations
  • 0fdfdf7: 8325983: Build failure after JDK-8324580
  • 3b1062d: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane
  • 5a988a5: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • a231706: 8324580: SIGFPE on THP initialization on kernels < 4.10
  • 2564f0f: 8325906: Problemlist vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java#id1 until JDK-8320865 is fixed
  • 9a1b843: 8324584: Optimize Symbol and char* handling in ClassLoader
  • a0e5e16: 8325162: Remove duplicate GCMParameters class
  • ... and 5 more: https://git.openjdk.org/jdk/compare/1aae980c549741cf5fc5ca51f3c299285bafa49d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 16, 2024
@openjdk openjdk bot closed this Feb 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 16, 2024
@openjdk
Copy link

openjdk bot commented Feb 16, 2024

@MBaesken Pushed as commit ba8db1f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants