Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8305895: Implementation: JEP 450: Compact Object Headers (Experimental) #17872

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rkennke
Copy link
Contributor

@rkennke rkennke commented Feb 15, 2024

WIP, in favor of #13961


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8306000 to be approved

Integration blockers

 ⚠️ Too few reviewers with at least role reviewer found (have 0, need at least 1) (failed with updated jcheck configuration in pull request)
 ⚠️ Whitespace errors (failed with updated jcheck configuration in pull request)

Issues

  • JDK-8305895: Implementation: JEP 450: Compact Object Headers (Experimental) (Enhancement - P4)
  • JDK-8306000: Add experimental -XX:+UseCompactObjectHeaders flag (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17872/head:pull/17872
$ git checkout pull/17872

Update a local copy of the PR:
$ git checkout pull/17872
$ git pull https://git.openjdk.org/jdk.git pull/17872/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17872

View PR using the GUI difftool:
$ git pr show -t 17872

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17872.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 15, 2024

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@rkennke rkennke marked this pull request as draft February 15, 2024 13:25
@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Feb 15, 2024
@openjdk
Copy link

openjdk bot commented Feb 15, 2024

@rkennke The following labels will be automatically applied to this pull request:

  • core-libs
  • graal
  • hotspot
  • serviceability
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org core-libs core-libs-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org and removed rfr Pull request is ready for review labels Feb 15, 2024
@openjdk
Copy link

openjdk bot commented Mar 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Mar 18, 2024

@rkennke this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8305895-v3
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org csr Pull request needs approved CSR before integration graal graal-dev@openjdk.org hotspot hotspot-dev@openjdk.org merge-conflict Pull request has merge conflict with target branch serviceability serviceability-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org
1 participant