8325972: Add -x to bash for building with LOG=debug

[magicus]

I don't understand why I have never thought of this before. If we add -x to the set of bash arguments when running with LOG=debug, we get output of all shell commands that make is running, even those for $(shell).

This makes it soooo much easier to understand what is actually happening in the makefile! (To the point where we could actually consider moving other stuff away from the debug level.)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8325972: Add -x to bash for building with LOG=debug (Enhancement - P3)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17875/head:pull/17875
$ git checkout pull/17875

Update a local copy of the PR:
$ git checkout pull/17875
$ git pull https://git.openjdk.org/jdk.git pull/17875/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17875

View PR using the GUI difftool:
$ git pr show -t 17875

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17875.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@magicus The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d821db71)

[erikj79]

Should we also disable the built in make command printing option for debug to avoid duplicate output?

[magicus]

I'm not sure, but I don't think so. Even if we get duplicate output, this way we can understand where things are coming from. I also think there is a difference in e.g. how variables are expanded.

At least, lets start here, and then we might go over the entire debug logging and see what we can cut out.

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325972: Add -x to bash for building with LOG=debug

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 9f4ec21: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
• 0aaec97: 8325763: Revert properties: vm.opt.x.*
• 4018b2b: 8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin
• 2705ed0: 8325074: ZGC fails assert(index == 0 || is_power_of_2(index)) failed: Incorrect load shift: 11
• 3d85103: 8316813: NMT: Using WhiteBox API, virtual memory tracking should also be stressed in JMH tests
• ba8db1f: 8325876: crashes in docker container tests on Linuxppc64le Power8 machines
• 18cea82: 8319801: Recursive lightweight locking: aarch64 implementation
• 9029bf6: 8316451: 6 java/lang/instrument/PremainClass tests ignore VM flags
• 99c9ae1: 8323664: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java still fails with JNI warning on some Windows configurations
• 0fdfdf7: 8325983: Build failure after JDK-8324580
• ... and 6 more: https://git.openjdk.org/jdk/compare/0d51b76947324643166cdaf9ca703431bd83bc0e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[magicus]

/integrate

[openjdk]

Going to push as commit 8668198.
Since your change was applied there have been 44 commits pushed to the master branch:

• a19314b: 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space
• f6d7e30: 8294977: Convert test/jdk/java tests from ASM library to Classfile API
• 82609b1: 8326112: Javadoc snippet for Linker.Option.captureCallState is wrong
• a776104: 8326106: Write and clear stack trace table outside of safepoint
• 56c5084: 8307246: Printing: banded raster path doesn't account for device offset values
• aeb6d8c: 8326170: Parallel: Remove unused enum CollectionType in ParallelScavengeHeap
• dc17c26: 8325116: Amend jdk.ContainerConfiguration by swap related value
• b366492: 8326152: Bad copyright header in test/jdk/java/util/zip/DeflaterDictionaryTests.java
• 9451677: 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut
• d422811: 8324630: C1: Canonicalizer::do_LookupSwitch doesn't break the loop when the successor is found
• ... and 34 more: https://git.openjdk.org/jdk/compare/0d51b76947324643166cdaf9ca703431bd83bc0e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus Pushed as commit 8668198.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.