Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319648: java/lang/SecurityManager tests ignore vm flags #17878

Closed
wants to merge 2 commits into from

Conversation

mpdonova
Copy link
Contributor

@mpdonova mpdonova commented Feb 15, 2024

In this PR I updated the tests to use the newer ProcessTools.createTestJavaProcessBuilder methods to pass VM options to child processes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8319648: java/lang/SecurityManager tests ignore vm flags (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17878/head:pull/17878
$ git checkout pull/17878

Update a local copy of the PR:
$ git checkout pull/17878
$ git pull https://git.openjdk.org/jdk.git pull/17878/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17878

View PR using the GUI difftool:
$ git pr show -t 17878

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17878.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 15, 2024

👋 Welcome back mdonovan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 15, 2024
@openjdk
Copy link

openjdk bot commented Feb 15, 2024

@mpdonova The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 15, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 15, 2024

Webrevs

@@ -131,13 +132,11 @@ static OutputAnalyzer checkInstallMessage(OutputAnalyzer oa, String cp) {
static OutputAnalyzer run(String prop, String cp) throws Exception {
ProcessBuilder pb;
if (prop == null) {
pb = new ProcessBuilder(
JDKToolFinder.getJDKTool("java"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the import of JDKToolFinder on line 31 now.

@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@mpdonova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319648: java/lang/SecurityManager tests ignore vm flags

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 175 new commits pushed to the master branch:

  • b8fc418: 8326525: com/sun/tools/attach/BasicTests.java does not verify AgentLoadException case
  • d9aa1de: 8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests
  • bbfda65: 8326897: (fs) The utility TestUtil.supportsLinks is wrongly used to check for hard link support
  • db0e2b8: 8326944: (ch) Minor typo in the ScatteringByteChannel.read(ByteBuffer[] dsts,int offset,int length) javadoc
  • 8f6edd8: 8326975: Parallel: Remove redundant PSOldGen::is_allocated
  • 4302900: 8319673: Few security tests ignore VM flags
  • e772e78: 8326948: Force English locale for timeout formatting
  • d9ef16d: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
  • 998d0ba: 8324799: Use correct extension for C++ test headers
  • 0735c8a: 8318302: ThreadCountLimit.java failed with "Native memory allocation (mprotect) failed to protect 16384 bytes for memory to guard stack pages"
  • ... and 165 more: https://git.openjdk.org/jdk/compare/a0e5e16afbd19f6396f0af2cba954225a357eca8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 29, 2024
@mpdonova
Copy link
Contributor Author

mpdonova commented Mar 1, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 1, 2024

Going to push as commit 437cf35.
Since your change was applied there have been 185 commits pushed to the master branch:

  • e85265a: 8325361: Make sun.net.www.MessageHeader final
  • 5b75199: 8327022: Parallel: Remove experimental dense prefix calculation
  • a065eba: 8326496: [test] checkHsErrFileContent support printing hserr in error case
  • 0899b3b: 8326612: Parallel: remove redundant assertion from ScavengeRootsTask
  • 12404a5: 8324790: ifnode::fold_compares_helper cleanup
  • 0d35450: 8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14
  • 8d6f784: 8327056: Remove unused static char array in JvmtiAgentList::lookup
  • 43af120: 8326959: Improve JVMCI option help
  • 742c776: 8322743: C2: prevent lock region elimination in OSR compilation
  • d29cefb: 8326838: JFR: Native mirror events
  • ... and 175 more: https://git.openjdk.org/jdk/compare/a0e5e16afbd19f6396f0af2cba954225a357eca8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 1, 2024
@openjdk openjdk bot closed this Mar 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 1, 2024
@openjdk
Copy link

openjdk bot commented Mar 1, 2024

@mpdonova Pushed as commit 437cf35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants