Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325994: JFR: Examples in JFR.start help use incorrect separator #17884

Closed
wants to merge 1 commit into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Feb 15, 2024

Could I have review of a fix that changes the separator in the help text for JFR.start from "," to " ".

Testing: jdk/jdk/jfr

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8325994: JFR: Examples in JFR.start help use incorrect separator (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17884/head:pull/17884
$ git checkout pull/17884

Update a local copy of the PR:
$ git checkout pull/17884
$ git pull https://git.openjdk.org/jdk.git pull/17884/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17884

View PR using the GUI difftool:
$ git pr show -t 17884

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17884.diff

Webrev

Link to Webrev Comment

@egahlin egahlin changed the title 8325994: JFR: Example in JFR.start help uses incorrect separator 8325994: JFR: Examples in JFR.start help uses incorrect separator Feb 15, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 15, 2024

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 15, 2024

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Feb 15, 2024
@egahlin egahlin changed the title 8325994: JFR: Examples in JFR.start help uses incorrect separator 8325994: JFR: Examples in JFR.start help use incorrect separator Feb 15, 2024
@egahlin egahlin marked this pull request as ready for review February 15, 2024 23:05
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 15, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 15, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325994: JFR: Examples in JFR.start help use incorrect separator

Reviewed-by: mikael

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 88 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 22, 2024
@egahlin
Copy link
Member Author

egahlin commented Feb 23, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Feb 23, 2024

Going to push as commit c4409ea.
Since your change was applied there have been 90 commits pushed to the master branch:

  • 54f09d7: 8278527: java/util/concurrent/tck/JSR166TestCase.java fails nanoTime test
  • 00ffc42: 8318761: MessageFormat pattern support for CompactNumberFormat, ListFormat, and DateTimeFormatter
  • d695af8: 8326376: java -version failed with CONF=fastdebug -XX:InitialCodeCacheSize=1024K -XX:ReservedCodeCacheSize=1200k
  • 9f9a732: 8325752: Remove badMetaWordVal
  • 864cf22: 8325742: Remove MetaWord usage from MemRegion
  • 8e5c0ee: 8324832: JFR: Improve sorting of 'jfr summary'
  • 724a2a2: 8321192: j.a.PrintJob/ImageTest/ImageTest.java: Fail or skip the test if there's no printer
  • f365d80: 8325153: SEGV in stackChunkOopDesc::derelativize_address(int)
  • 4406915: 8323274: C2: array load may float above range check
  • cc1e216: 8326461: tools/jlink/CheckExecutable.java fails as .debuginfo files are not executable
  • ... and 80 more: https://git.openjdk.org/jdk/compare/0fdfdf71f242b39f2e758fcff99bd61060fa2870...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 23, 2024
@openjdk openjdk bot closed this Feb 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 23, 2024
@openjdk
Copy link

openjdk bot commented Feb 23, 2024

@egahlin Pushed as commit c4409ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants