8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE

[RealCLanger]

The experimental SunJSSE FIPS compliant mode was removed in JDK13 with JDK-8217835.
It seems the removal of some comments had been missed at that time. This could be irritating to readers of the code.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE (Bug - P4)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)
• Anthony Scarpino (@ascarpino - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17885/head:pull/17885
$ git checkout pull/17885

Update a local copy of the PR:
$ git checkout pull/17885
$ git pull https://git.openjdk.org/jdk.git pull/17885/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17885

View PR using the GUI difftool:
$ git pr show -t 17885

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17885.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealCLanger The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7ba4c017)
• 00: Full (ae7b7388)

[ascarpino]

You will need to update the copyright on the file.

[RealCLanger]

You will need to update the copyright on the file.

Right. Updated.

[MBaesken]

Makes sense to remove the comment, it is more historical these days.
Or is there still a way to use SunJSSE FIPS compliant mode ?

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE

Reviewed-by: mbaesken, ascarpino

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 3b76372: 8325687: SimpleJavaFileObject specification would benefit from implSpec
• b5df2f4: 8323170: j2dbench is using outdated javac source/target to be able to build by itself
• 267780b: 8324680: Replace NULL with nullptr in JVMTI generated code
• f3073db: 8321408: Add Certainly roots R1 and E1
• 4c7b313: 8325908: Finish removal of IntlTest and CollatorTest
• 5310250: 8325941: Remove unused Space::block_size
• 7a76252: 8325990: Remove use of snippet @replace annotation in java.base
• 00b5c70: 8326062: ProblemList jcstress tests that are failing due to JDK-8325984
• 4388095: 8325326: [PPC64] Don't relocate in case of allocation failure
• 244573e: 8265372: Simplify PKCS9Attribute
• ... and 3 more: https://git.openjdk.org/jdk/compare/4018b2b19629ddb8cd7a56e064dfef371f23e5fa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[ascarpino]

Makes sense to remove the comment, it is more historical these days. Or is there still a way to use SunJSSE FIPS compliant mode ?

There is no FIPS compliant mode. This was a experimental feature that was never supported.

[RealCLanger]

/integrate

[openjdk]

Going to push as commit c2d9fa2.
Since your change was applied there have been 15 commits pushed to the master branch:

• f50df10: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
• cf13086: 8317697: refactor-encapsulate x86 VM_Version::CpuidInfo
• 3b76372: 8325687: SimpleJavaFileObject specification would benefit from implSpec
• b5df2f4: 8323170: j2dbench is using outdated javac source/target to be able to build by itself
• 267780b: 8324680: Replace NULL with nullptr in JVMTI generated code
• f3073db: 8321408: Add Certainly roots R1 and E1
• 4c7b313: 8325908: Finish removal of IntlTest and CollatorTest
• 5310250: 8325941: Remove unused Space::block_size
• 7a76252: 8325990: Remove use of snippet @replace annotation in java.base
• 00b5c70: 8326062: ProblemList jcstress tests that are failing due to JDK-8325984
• ... and 5 more: https://git.openjdk.org/jdk/compare/4018b2b19629ddb8cd7a56e064dfef371f23e5fa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit c2d9fa2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.