8326006: Allow TEST_VM_FLAGLESS to set flagless mode

[lmesnik]

Allow TEST_VM_FLAGLESS to enable/disable flagless tests execution explicitly.
Sometimes the tests are executed in the mode that is incompatible with flag-sensitive tests. This mode should be able to disable them explicitly.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8326006: Allow TEST_VM_FLAGLESS to set flagless mode (Enhancement - P4)

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer) ⚠️ Review applies to 65859eed
• Albert Mingkun Yang (@albertnetymk - Reviewer) ⚠️ Review applies to 65859eed

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17886/head:pull/17886
$ git checkout pull/17886

Update a local copy of the PR:
$ git checkout pull/17886
$ git pull https://git.openjdk.org/jdk.git pull/17886/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17886

View PR using the GUI difftool:
$ git pr show -t 17886

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17886.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lmesnik To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[lmesnik]

/cc hotspot

[openjdk]

@lmesnik
The hotspot label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (b9aeeb77)
• 00: Full (65859eed)

[lmesnik]

/cc hotspot-gc

[openjdk]

@lmesnik
The hotspot-gc label was successfully added.

[tschatzl]

I would slightly prefer extracting the System.getenv() call into a local and reusing it, but this is fine as well.

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326006: Allow TEST_VM_FLAGLESS to set flagless mode

Reviewed-by: tschatzl, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 98 new commits pushed to the master branch:

• 27574b3: 8326585: COMPARE_BUILD=PATCH fails if patch -R fails
• c26c583: 8311003: missing @SInCE info in jdk.security.jgss
• 09a78b5: 8326378: [PPC64] CodeEntryAlignment too large
• ef2d5c4: 8326065: Merge Space into ContiguousSpace
• 11fdca0: 8325202: gc/g1/TestMarkStackOverflow.java intermittently crash: G1CMMarkStack::ChunkAllocator::allocate_new_chunk
• 5d414da: 8325372: Shenandoah: SIGSEGV crash in unnecessary_acquire due to LoadStore split through phi
• 93a2e77: 8326129: Java Record Pattern Match leads to infinite loop
• 336bbbe: 8139457: Relax alignment of array elements
• cb809f8: 8325215: Incorrect not exhaustive switch error
• c4409ea: 8325994: JFR: Examples in JFR.start help use incorrect separator
• ... and 88 more: https://git.openjdk.org/jdk/compare/9029bf644e238a504e1f114a73edf5760d19980b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lmesnik]

/integrate

[openjdk]

Going to push as commit d10f277.
Since your change was applied there have been 99 commits pushed to the master branch:

• 63f6a56: 8326530: Widen allowable error bound of Math.tan
• 27574b3: 8326585: COMPARE_BUILD=PATCH fails if patch -R fails
• c26c583: 8311003: missing @SInCE info in jdk.security.jgss
• 09a78b5: 8326378: [PPC64] CodeEntryAlignment too large
• ef2d5c4: 8326065: Merge Space into ContiguousSpace
• 11fdca0: 8325202: gc/g1/TestMarkStackOverflow.java intermittently crash: G1CMMarkStack::ChunkAllocator::allocate_new_chunk
• 5d414da: 8325372: Shenandoah: SIGSEGV crash in unnecessary_acquire due to LoadStore split through phi
• 93a2e77: 8326129: Java Record Pattern Match leads to infinite loop
• 336bbbe: 8139457: Relax alignment of array elements
• cb809f8: 8325215: Incorrect not exhaustive switch error
• ... and 89 more: https://git.openjdk.org/jdk/compare/9029bf644e238a504e1f114a73edf5760d19980b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lmesnik Pushed as commit d10f277.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.