Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326062: ProblemList jcstress tests that are failing due to JDK-8325984 #17890

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Feb 16, 2024

A trivial fix to ProblemList jcstress tests that are failing due to JDK-8325984.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8326062: ProblemList jcstress tests that are failing due to JDK-8325984 (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17890/head:pull/17890
$ git checkout pull/17890

Update a local copy of the PR:
$ git checkout pull/17890
$ git pull https://git.openjdk.org/jdk.git pull/17890/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17890

View PR using the GUI difftool:
$ git pr show -t 17890

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17890.diff

Webrev

Link to Webrev Comment

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add core-libs

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review February 16, 2024 15:54
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 16, 2024

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Feb 16, 2024
@openjdk
Copy link

openjdk bot commented Feb 16, 2024

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 16, 2024
@openjdk
Copy link

openjdk bot commented Feb 16, 2024

@dcubed-ojdk
The core-libs label was successfully added.

@openjdk
Copy link

openjdk bot commented Feb 16, 2024

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326062: ProblemList jcstress tests that are failing due to JDK-8325984

Reviewed-by: azvegint, jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 4388095: 8325326: [PPC64] Don't relocate in case of allocation failure

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 16, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 16, 2024

Webrevs

@dcubed-ojdk
Copy link
Member Author

@azvegint - Thanks for the fast review!

/integrate

Copy link
Member

@JornVernee JornVernee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openjdk
Copy link

openjdk bot commented Feb 16, 2024

Going to push as commit 00b5c70.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 4388095: 8325326: [PPC64] Don't relocate in case of allocation failure

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 16, 2024
@openjdk openjdk bot closed this Feb 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 16, 2024
@openjdk
Copy link

openjdk bot commented Feb 16, 2024

@dcubed-ojdk Pushed as commit 00b5c70.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8326062 branch February 17, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants