8326065: Merge Space into ContiguousSpace

[albertnetymk]

Merging a super class into its single sub class.

Test: tier1-6

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8326065: Merge Space into ContiguousSpace (Enhancement - P4)

Reviewers

• Chris Plummer (@plummercj - Reviewer)
• Stefan Johansson (@kstefanj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17891/head:pull/17891
$ git checkout pull/17891

Update a local copy of the PR:
$ git checkout pull/17891
$ git pull https://git.openjdk.org/jdk.git pull/17891/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17891

View PR using the GUI difftool:
$ git pr show -t 17891

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17891.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following labels will be automatically applied to this pull request:

• hotspot-gc
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (10216e29)

[plummercj]

The changes look good. It looks like the GenerationFactory removal is something that should have previously been done. Is that the case, or is there something about Space/ContiguousSpace merger that made it possible to remove GenerationFactory?

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326065: Merge Space into ContiguousSpace

Reviewed-by: cjplummer, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 76 new commits pushed to the master branch:

• c4409ea: 8325994: JFR: Examples in JFR.start help use incorrect separator
• 54f09d7: 8278527: java/util/concurrent/tck/JSR166TestCase.java fails nanoTime test
• 00ffc42: 8318761: MessageFormat pattern support for CompactNumberFormat, ListFormat, and DateTimeFormatter
• d695af8: 8326376: java -version failed with CONF=fastdebug -XX:InitialCodeCacheSize=1024K -XX:ReservedCodeCacheSize=1200k
• 9f9a732: 8325752: Remove badMetaWordVal
• 864cf22: 8325742: Remove MetaWord usage from MemRegion
• 8e5c0ee: 8324832: JFR: Improve sorting of 'jfr summary'
• 724a2a2: 8321192: j.a.PrintJob/ImageTest/ImageTest.java: Fail or skip the test if there's no printer
• f365d80: 8325153: SEGV in stackChunkOopDesc::derelativize_address(int)
• 4406915: 8323274: C2: array load may float above range check
• ... and 66 more: https://git.openjdk.org/jdk/compare/53102502c3f08bef8251a0a2bb361a2f09099576...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

It looks like the GenerationFactory removal is something that should have previously been done.

True; I overlooked it until the removal of SpaceClosure in this PR.

[kstefanj]

Looks good, feels like the files should change name as well. Now when there no longer is a Space. But maybe that's even better to do once we have moved TenuredSpace into Serial. 

[albertnetymk]

Thanks for review.

/integrate

[openjdk]

Going to push as commit ef2d5c4.
Since your change was applied there have been 81 commits pushed to the master branch:

• 11fdca0: 8325202: gc/g1/TestMarkStackOverflow.java intermittently crash: G1CMMarkStack::ChunkAllocator::allocate_new_chunk
• 5d414da: 8325372: Shenandoah: SIGSEGV crash in unnecessary_acquire due to LoadStore split through phi
• 93a2e77: 8326129: Java Record Pattern Match leads to infinite loop
• 336bbbe: 8139457: Relax alignment of array elements
• cb809f8: 8325215: Incorrect not exhaustive switch error
• c4409ea: 8325994: JFR: Examples in JFR.start help use incorrect separator
• 54f09d7: 8278527: java/util/concurrent/tck/JSR166TestCase.java fails nanoTime test
• 00ffc42: 8318761: MessageFormat pattern support for CompactNumberFormat, ListFormat, and DateTimeFormatter
• d695af8: 8326376: java -version failed with CONF=fastdebug -XX:InitialCodeCacheSize=1024K -XX:ReservedCodeCacheSize=1200k
• 9f9a732: 8325752: Remove badMetaWordVal
• ... and 71 more: https://git.openjdk.org/jdk/compare/53102502c3f08bef8251a0a2bb361a2f09099576...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit ef2d5c4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.