Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326090: Rename jvmti_aod.h #17895

Closed
wants to merge 3 commits into from
Closed

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Feb 16, 2024

Please review this trivial change that renames the file
test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/aod/jvmti_aod.h to jvmti_aod.hpp,
and replace uses of NULL in the file.

The #include updates were performed mechanically, and build would fail if
there were mistakes. All of the including files have already had their
copyrights updated recently, as part of JDK-8324681. So the only interesting
(for some minimal value of "interesting") changes are in the renamed file.

Testing: mach5 tier1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17895/head:pull/17895
$ git checkout pull/17895

Update a local copy of the PR:
$ git checkout pull/17895
$ git pull https://git.openjdk.org/jdk.git pull/17895/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17895

View PR using the GUI difftool:
$ git pr show -t 17895

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17895.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 16, 2024

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 16, 2024
@openjdk
Copy link

openjdk bot commented Feb 16, 2024

@kimbarrett The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Feb 16, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 16, 2024

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented Feb 20, 2024

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326090: Rename jvmti_aod.h

Reviewed-by: coleenp, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 20, 2024
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for taking care about it.

@kimbarrett
Copy link
Author

Thanks for reviewing, @coleenp and @sspitsyn .

@kimbarrett
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

Going to push as commit 27003b5.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 21, 2024
@openjdk openjdk bot closed this Feb 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 21, 2024
@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@kimbarrett Pushed as commit 27003b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the jvmti_aod branch February 21, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants