-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8325610: CTW: Add StressIncrementalInlining to stress options #17897
Conversation
👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into |
@caojoshua The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
@@ -299,6 +299,7 @@ private String[] cmd(long classStart, long classStop) { | |||
"-XX:+StressIGVN", | |||
"-XX:+StressCCP", | |||
"-XX:+StressMacroExpansion", | |||
"-XX:+StressIncrementalInlining", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to maintain the historical order here. Check me on this: StressIncrementalInlining
went in before StressMacroExpansion
, but after StressCCP
, and so should be one line up?
@caojoshua This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 26 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @navyxliu) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@caojoshua |
I'll wait for another reviewer before sponsoring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I am not a reviewer.
/sponsor |
Going to push as commit 5bf859c.
Your commit was automatically rebased without conflicts. |
@shipilev @caojoshua Pushed as commit 5bf859c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
CtwRunner opts-in into various C2 randomizers
I think we forgot to add -XX:+StressIncrementalInlining there, which was added by JDK-8319879.
tested by
./ctwrunner.sh modules:java.base
I can see
-XX:+StressIncrementalInlining
inmodules_java_base_0.cmd
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17897/head:pull/17897
$ git checkout pull/17897
Update a local copy of the PR:
$ git checkout pull/17897
$ git pull https://git.openjdk.org/jdk.git pull/17897/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17897
View PR using the GUI difftool:
$ git pr show -t 17897
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17897.diff
Webrev
Link to Webrev Comment