Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252196: ZGC: TestUncommit.java fails due to "Exception: Uncommitted too fast" again(2) #179

Closed
wants to merge 1 commit into from

Conversation

@pliden
Copy link
Contributor

@pliden pliden commented Sep 15, 2020

This test has failed a few times because the timeAfterAlloc timestamp (the time when uncommit can start to happen) is taken at the wrong place. We should take this timestamp before we call allocate(), since the allocation could cause ZPageCache::_last_commit to be set, which will dictate when uncommit can happen. This PR moves and renames timeAfterAlloc accordingly.

Testing: gc/z/TestUncommit.java executed multiple times on all platforms.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252196: ZGC: TestUncommit.java fails due to "Exception: Uncommitted too fast" again(2)

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/179/head:pull/179
$ git checkout pull/179

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 15, 2020

👋 Welcome back pliden! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@pliden The following label will be automatically applied to this pull request: hotspot-gc.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot-gc label Sep 15, 2020
@pliden pliden marked this pull request as ready for review Sep 15, 2020
@openjdk openjdk bot added the rfr label Sep 15, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 15, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@pliden This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252196: ZGC: TestUncommit.java fails due to "Exception: Uncommitted too fast" again(2)

Reviewed-by: stefank, eosterlund
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 34 commits pushed to the master branch:

  • a9993f9: 8253275: Remove unused methods after CMS removal
  • 4ac6934: 8253232: G1Analytics::compute_pause_time_ratios() uses wrong pause times in calculation
  • 53a4ef2: 8202473: A type variable with multiple bounds does not correctly place type annotation
  • b87a159: 8252100: NumberOverflow in class MemoryCache
  • 9a7dcdc: 8253261: Disable CDS full module graph until JDK-8253081 is fixed
  • 1c84cfa: 8253130: bug7072653.java failed "Popup window height ... is wrong"
  • ce93cbc: 8253125: vmTestbase/nsk/stress/stack/stack017.java timed out
  • d250f9e: 8253244: Shenandoah: cleanup includes in Shenandoah root processor files
  • d38c97d: 8253207: enable problemlists jcheck's check
  • 671dfba: 6714834: JarFile.getManifest() leaves an open InputStream as an undocumented side effect
  • ... and 24 more: https://git.openjdk.java.net/jdk/compare/d219d8b9871be037815413e6f52bc85ebac8db2a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate a9993f9464a724637b3d38bd2f6caedf884d3e0b.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 15, 2020
fisk
fisk approved these changes Sep 17, 2020
@pliden
Copy link
Contributor Author

@pliden pliden commented Sep 17, 2020

/integrate

@openjdk openjdk bot closed this Sep 17, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2020

@pliden Since your change was applied there have been 34 commits pushed to the master branch:

  • a9993f9: 8253275: Remove unused methods after CMS removal
  • 4ac6934: 8253232: G1Analytics::compute_pause_time_ratios() uses wrong pause times in calculation
  • 53a4ef2: 8202473: A type variable with multiple bounds does not correctly place type annotation
  • b87a159: 8252100: NumberOverflow in class MemoryCache
  • 9a7dcdc: 8253261: Disable CDS full module graph until JDK-8253081 is fixed
  • 1c84cfa: 8253130: bug7072653.java failed "Popup window height ... is wrong"
  • ce93cbc: 8253125: vmTestbase/nsk/stress/stack/stack017.java timed out
  • d250f9e: 8253244: Shenandoah: cleanup includes in Shenandoah root processor files
  • d38c97d: 8253207: enable problemlists jcheck's check
  • 671dfba: 6714834: JarFile.getManifest() leaves an open InputStream as an undocumented side effect
  • ... and 24 more: https://git.openjdk.java.net/jdk/compare/d219d8b9871be037815413e6f52bc85ebac8db2a...master

Your commit was automatically rebased without conflicts.

Pushed as commit f972155.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pliden pliden deleted the 8252196_zgc_test_uncommit branch Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants